Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#26364] - [4.0] [com_menus] Prepared statements

? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
20 Sep 2019

Summary of Changes

Adds prepared statements and cleans up queries in com_menus.

Testing Instructions

Do stuff in com_menus. Browse around, search and filter menu items/types, create/edit/unpublish menu items and types, use rebuild function, set associations, etc.

Expected result

Works like before.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 20 Sep 2019
avatar SharkyKZ SharkyKZ - change - 20 Sep 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2019
Category ⇒ Administration com_menus
avatar SharkyKZ SharkyKZ - change - 20 Sep 2019
Title
…
J4/prepared/com menus
[4.0] [com_menus] Prepared statements
avatar SharkyKZ SharkyKZ - edited - 20 Sep 2019
2dfb80a 20 Sep 2019 avatar SharkyKZ CS
avatar SharkyKZ SharkyKZ - change - 20 Sep 2019
Labels Added: ?
422d577 20 Sep 2019 avatar SharkyKZ CS
avatar Laurentdubois59 Laurentdubois59 - test_item - 20 Sep 2019 - Tested unsuccessfully
avatar Laurentdubois59
Laurentdubois59 - comment - 20 Sep 2019

I have tested this item ? unsuccessfully on 422d577

Hello, when I applied this patch my left menu to disappear.
https://www.mobilemedia.fr/joom4/images/menu.jpg
Thanks
Laurent

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26364.

3ee309a 20 Sep 2019 avatar SharkyKZ Order
avatar SharkyKZ
SharkyKZ - comment - 20 Sep 2019

@Laurentdubois59 What database are you using?

20f8094 21 Sep 2019 avatar SharkyKZ Order
avatar alikon alikon - test_item - 22 Sep 2019 - Tested successfully
avatar alikon
alikon - comment - 22 Sep 2019

I have tested this item ✅ successfully on 20f8094

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26364.

avatar Quy Quy - test_item - 27 Sep 2019 - Tested successfully
avatar Quy
Quy - comment - 27 Sep 2019

I have tested this item ✅ successfully on 445436d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26364.

avatar chmst
chmst - comment - 19 Oct 2019

It seems to be all right, just a Language string is missing COM_MENUS_ITEMS_SET_HOME (should be either _1 or _MORE)

avatar chmst chmst - test_item - 19 Oct 2019 - Tested successfully
avatar chmst
chmst - comment - 19 Oct 2019

I have tested this item ✅ successfully on f67331b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26364.

avatar Quy Quy - change - 19 Oct 2019
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 19 Oct 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26364.

avatar joeykrop joeykrop - test_item - 19 Oct 2019 - Tested successfully
avatar joeykrop
joeykrop - comment - 19 Oct 2019

I have tested this item ✅ successfully on 8b23562

Tested all features discussed in the PR.

"Do stuff in com_menus. Browse around, search and filter menu items/types, create/edit/unpublish menu items and types, use rebuild function, set associations, etc."

All features worked as before.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26364.

avatar ttplpoojak ttplpoojak - test_item - 19 Oct 2019 - Tested successfully
avatar ttplpoojak
ttplpoojak - comment - 19 Oct 2019

I have tested this item ✅ successfully on 8b23562

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26364.

avatar wilsonge wilsonge - change - 19 Oct 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-10-19 13:23:13
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 19 Oct 2019

Thanks!

Add a Comment

Login with GitHub to post a comment