Feeling Lucky
?
[#26361] - Remove unused variable
- Fixed in Code Base
- 19 Oct 2019
- Medium
- Build: staging
- # 26361
- Diff
- Quy:remove-variable
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Remove $fullWidth as it is not being used.
Testing Instructions
Code review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
alikon
- comment
- 19 Sep 2019
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26361.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 19 Sep 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26361.
brianteeman
- comment
- 19 Sep 2019
I am wary of this being committed in a patch release
alikon
- comment
- 19 Sep 2019
i'm afraid we will only have 3.10 .... what i'm missing ?
SharkyKZ
- comment
- 20 Sep 2019
It's just a local variable. Fine to go in 3.9.xx.
infograf768
- comment
- 20 Sep 2019
As we have been living with it since 3.0.0 without any side effects and @HLeithner wants to minimize changes in the stable vs RC, let's just merge in 3.10.0 ;)
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-19 21:31:28 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 19 Oct 2019
Thanks!
I have tested this item✅ successfully on df6cc4b
I can confirm that the variable is not used anywhere in J3 core.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26361.