NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
19 Sep 2019

Pull Request for Issue #26356

Summary of Changes

Fix the core-loader web component on RTL

Testing Instructions

  • Modify installation/language/en-GB/en-GB.xml to set it to RTL: <rtl>1</rtl>
  • Install Joomla.

Demo Codepen: https://codepen.io/charlie-lodder/pen/rNBQBev

avatar C-Lodder C-Lodder - open - 19 Sep 2019
avatar C-Lodder C-Lodder - change - 19 Sep 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2019
Category Repository NPM Change
avatar C-Lodder C-Lodder - change - 19 Sep 2019
Labels Added: NPM Resource Changed ?
avatar C-Lodder C-Lodder - change - 19 Sep 2019
Title
Fix core loader on RTL
[4.0] Fix core loader on RTL
avatar C-Lodder C-Lodder - edited - 19 Sep 2019
avatar infograf768 infograf768 - test_item - 19 Sep 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 19 Sep 2019

I have tested this item successfully on bd1d8ad

Works fine. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26358.

avatar infograf768
infograf768 - comment - 19 Sep 2019

@wilsonge
Good to go.

avatar alikon alikon - test_item - 19 Sep 2019 - Tested successfully
avatar alikon
alikon - comment - 19 Sep 2019

I have tested this item successfully on bd1d8ad


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26358.

avatar alikon alikon - change - 19 Sep 2019
Status Pending Ready to Commit
avatar alikon
alikon - comment - 19 Sep 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26358.

avatar wilsonge wilsonge - change - 23 Sep 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-09-23 09:26:59
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 23 Sep 2019
avatar wilsonge wilsonge - merge - 23 Sep 2019
avatar wilsonge
wilsonge - comment - 23 Sep 2019

Thanks!

Add a Comment

Login with GitHub to post a comment