? ?

Pending

User tests: Successful: Unsuccessful:

avatar artur-stepien
artur-stepien
16 Sep 2019

mod_articles_category detects category as active only in category view. Where this should also work for categories view. This fixes the problem.

Pull Request for Issue # .

Summary of Changes

Detect active category also in categories view

Testing Instructions

Create articles categories tree as follows:
A
A -> B
A -> C
A -> C -> D
A -> C -> E

Create new module of type "mod_articles_categories"
Set Parent Category as A
Set Show Subcategories to Yes
As Position set any position that will display the module.
Set the module to display on all pages.
Save the module.
Create a new menu item with Menu Item Type set to List All Categories, then set Select a Top Level Category to C.
Go to front-end
Find the menu item you just created and click it.

Expected result

Category C in mod_articles_categories you created before should have the "active" class on <li> element.

Actual result

C in articles categories module does not have the active class.

Documentation Changes Required

avatar artur-stepien artur-stepien - open - 16 Sep 2019
avatar artur-stepien artur-stepien - change - 16 Sep 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Sep 2019
Category Modules Front End
avatar artur-stepien artur-stepien - change - 16 Sep 2019
Title
Fixing "active" category detected
Fixing "active" category detection in mod_articles_categories
avatar artur-stepien artur-stepien - edited - 16 Sep 2019
avatar infograf768 infograf768 - change - 22 Sep 2019
Labels Added: ?
avatar ladyjer ladyjer - test_item - 19 Oct 2019 - Tested successfully
avatar ladyjer
ladyjer - comment - 19 Oct 2019

I have tested this item successfully on 41eac93


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26330.

avatar euismod2336 euismod2336 - test_item - 19 Oct 2019 - Tested successfully
avatar euismod2336
euismod2336 - comment - 19 Oct 2019

I have tested this item successfully on 41eac93

After applying patch, the active class is also set in the categories view


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26330.

avatar Quy Quy - change - 19 Oct 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 19 Oct 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26330.

avatar HLeithner HLeithner - change - 29 Oct 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-29 14:11:04
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 29 Oct 2019
avatar HLeithner HLeithner - merge - 29 Oct 2019
avatar HLeithner
HLeithner - comment - 29 Oct 2019

Thanks

Add a Comment

Login with GitHub to post a comment