[#26330] - Fixing "active" category detection in mod_articles_categories
- Fixed in Code Base
- 29 Oct 2019
- Medium
- Build: staging
- # 26330
- Diff
- artur-stepien:patch-10
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
mod_articles_category detects category as active only in category view. Where this should also work for categories view. This fixes the problem.
Pull Request for Issue # .
Summary of Changes
Detect active category also in categories view
Testing Instructions
Create articles categories tree as follows:
A
A -> B
A -> C
A -> C -> D
A -> C -> E
Create new module of type "mod_articles_categories"
Set Parent Category as A
Set Show Subcategories to Yes
As Position set any position that will display the module.
Set the module to display on all pages.
Save the module.
Create a new menu item with Menu Item Type set to List All Categories, then set Select a Top Level Category to C.
Go to front-end
Find the menu item you just created and click it.
Expected result
Category C in mod_articles_categories you created before should have the "active" class on <li> element.
Actual result
C in articles categories module does not have the active class.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Title |
|
||||||
| Labels |
Added:
?
|
||
I have tested this item
After applying patch, the active class is also set in the categories view
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26330.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26330.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-29 14:11:04 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item✅ successfully on 41eac93
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26330.