? ?
avatar unknown-sudo
unknown-sudo
15 Sep 2019

The edit module icon in the backend has a title "Edit site" or "Edit system" and so on. I think it would be more appropriate to name it more detailed. "Edit the System information Module" or similar. "Edit System" would lead me to the configuration rather than to the module. Behind "Edit Sample Data" I would also expect something different.

avatar unknown-sudo unknown-sudo - open - 15 Sep 2019
avatar joomla-cms-bot joomla-cms-bot - change - 15 Sep 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 15 Sep 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 15 Sep 2019
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 15 Sep 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 15 Sep 2019
Status New Discussion
avatar brianteeman
brianteeman - comment - 16 Sep 2019

You are correct

But currently the option in that submenu are actually incorrect so I would like to wait until that is resolved before resolving the text

avatar infograf768
infograf768 - comment - 16 Sep 2019

The title for the cog icon is defined by the module title
<span class="sr-only"><?php echo Text::_('JACTION_EDIT') . ' ' . $module->title; ?></span>
Change the modules titles and you will get what you need.

Imho we have another issue in the sense that it does not use at least a sprintf for multilingual better use.

We need a new constant, for example JACTION_EDIT_MODULE
JACTION_EDIT_MODULE="Edit the '%s' module"

code would be:
<?php echo Text::sprintf('JACTION_EDIT_MODULE', $module->title); ?>

avatar Quy Quy - change - 23 Sep 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-09-23 15:52:42
Closed_By Quy
avatar Quy Quy - close - 23 Sep 2019
avatar Quy
Quy - comment - 23 Sep 2019

Please test PR #26382


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26321.

Add a Comment

Login with GitHub to post a comment