[#2629] - Fix for unsupported comment tag ( //)
- Closed
- 15 May 2014
- Medium
- Build: master
- # 2629
- Diff
- gauravjain028:master
- Error This pull request is targeted at the master branch. Pull requests should no longer be merged to master.
User tests: Successful: Unsuccessful:
// > Joomla JUI and // < Joomla JUI are used for for commenting purpose. Which is not supported in css.
This issue is generated due to that commit. In last commit /*<<< JUI <<< */ is replaced with // < JUI. That is okay with .less file, but in .css file it is causing issue.
In last commit same thing is done in bootstrap.css file also.
https://github.com/joomla/joomla-cms/blob/master/media/jui/css/bootstrap.css
at line number 6138
FullACK.
Single-Line comments are not allowed in CSS and should be erased by LESS-parsers (see http://lesscss.org/#-comments)
Thanks for your contribution. Can you please open a related item on the tracker http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103 so that it can be tested etc
This makes sense.
This PR is against the wrong branch. Can you submit it to the right one? The code makes sense and looks good.
In which branch it should be committed?
Staging?
Yep, staging is the correct one.
| Title |
|
||||||
| Status | New | ⇒ | Closed | ||||
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-05-15 08:55:32 | ||||
This was introduced here http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32345