J4 Issue ?
avatar brianteeman
brianteeman
13 Sep 2019

After installing a language you get the following message

image

Which is a bit confusing because as far as the user is concerned they installed a language not a package.

@infograf768 did make a change for this in J3 #10523

https://github.com/infograf768/joomla-cms/blob/940a8223567863af3e9b7142d31180cbeb1d6b23/administrator/components/com_installer/models/languages.php#L303

but it looks like that change has gone

avatar brianteeman brianteeman - open - 13 Sep 2019
avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 13 Sep 2019
avatar infograf768
infograf768 - comment - 13 Sep 2019

Not specially related to 4.0
The code has been changed drastically since 2016.
Now we have a general string for any package
$msg = JText::sprintf('COM_INSTALLER_INSTALL_SUCCESS', JText::_('COM_INSTALLER_TYPE_TYPE_' . strtoupper($package['type'])));

in .../administrator/components/com_installer/models/install.php line 197

avatar infograf768
infograf768 - comment - 13 Sep 2019

It uses COM_INSTALLER_TYPE_TYPE_PACKAGE="package" instead of COM_INSTALLER_TYPE_TYPE_LANGUAGE="language" because one can still (I guess. Would have to test) install a single language (site or admin) which would not be presented as a pack. (That kind is not proposed by core)

avatar infograf768
infograf768 - comment - 13 Sep 2019

Example whne I Installed the Russian admin.zip via extension install
Screen Shot 2019-09-13 at 12 41 50

avatar franz-wohlkoenig franz-wohlkoenig - change - 13 Sep 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 13 Sep 2019
avatar brianteeman
brianteeman - comment - 13 Sep 2019

Either we need to have a new way of saying that a language pack has been installed (similar to the old way) or at a minimum the unused language string should be removed

avatar mbabker
mbabker - comment - 13 Sep 2019

Without some kind of special attribute or some way to identify a language pack within the package adapter you won’t get the desired end state anywhere that isn’t the languages install page. Because ultimately a language pack is just a collection of language extensions, and I don’t think it’s a good idea to try and assume something is a language pack based on file name or it only containing a certain extension type.

avatar infograf768
infograf768 - comment - 13 Sep 2019

And, in any case, one can install (although not recommanded by core), a single language as an extension and not as a pack. Which means we should keep the string.

avatar brianteeman
brianteeman - comment - 13 Sep 2019

It is crazy that on a page that can only install a language there can not be a message that says you installed a language. Saying that its not possible is something I can not believe.

avatar brianteeman
brianteeman - comment - 13 Sep 2019

I guess I wasn't clear enough that I was referring to installing a language the recommended way using the language specific install page and not the generic extension installer

avatar franz-wohlkoenig franz-wohlkoenig - change - 13 Sep 2019
Status New Discussion
avatar infograf768
infograf768 - comment - 13 Sep 2019

It was clear. Just explaining why we should keep the string. @mbabker explained the package issue.

avatar mbabker
mbabker - comment - 13 Sep 2019

git blame says 204ef46 undid that change. So it was added in 3.6 and removed in 3.7 without notice.

avatar infograf768
infograf768 - comment - 14 Sep 2019

That PR was real good and this very small side effect is imho epiphenomenic.

avatar brianteeman
brianteeman - comment - 14 Sep 2019

When using big words its helpful to use the correct one.

Side effect or not - it should be fixed

avatar infograf768
infograf768 - comment - 15 Sep 2019

Then fix it. The word is correct. Learning semantics can be very useful for computer code as well as daily life. ROTFLOL

avatar brianteeman
brianteeman - comment - 15 Sep 2019

I will fix it. You are just stubbornly refusing to consider anything that was not your idea or that you overlooked

avatar infograf768
infograf768 - comment - 15 Sep 2019

Stop insulting people please.

avatar infograf768 infograf768 - change - 15 Sep 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-09-15 10:29:12
Closed_By infograf768
avatar infograf768
infograf768 - comment - 15 Sep 2019

Closing as we have a patch #26310

avatar infograf768 infograf768 - close - 15 Sep 2019

Add a Comment

Login with GitHub to post a comment