[#26273] - [4.0] Handle PDO driver database creation
- Closed
- 15 Mar 2020
- Medium
- Build: 4.0-dev
- # 26273
- Diff
- roland-d:feature/handle-pdo-db-creation
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25885
Summary of Changes
This change makes sure a database will be created during the installation of Joomla.
Testing Instructions
- Get a clean copy of Joomla 4
- Start the installation process
- Go through the process until you get to the database part
- Select here the PDO driver
- Fill-in a database name that doesn't exist yet
- Complete the installation
- Installation doesn't complete because the database name does not exist.
- Clean the session cookies
- Apply the patch
- Restart the installation process
- Go through the process until you get to the database part
- Select here the PDO driver
- Fill-in a database name that doesn't exist yet
- Complete the installation
- Installation completes successfully
Expected result
The database will be created by the installer
Actual result
The database is not created and throws an error
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
| Title |
|
||||||
| Labels |
Added:
?
|
||
Works fine on MySQL PDO but getting authentication error on PostgreSQL:
Could not connect to PDO: SQLSTATE[08006] [7] FATAL: password authentication failed for user
For what it's worth, creating DB on PgSQL doesn't work in 3.x either. So maybe limit this change to MySQL PDO only to restore 3.x behavior?
@brianteeman I have no opinion regarding this. Are you suggesting to remove the ability to create database during installation?
basically yes. although its useful when building a site locally its something that is pretty unique to joomla iirc
It is not only useful for building sites locally. If you create sites on
the fly, it is also a very useful feature. Like I do for the pbf testing
sites for example. I really don't want to create a 100 databases by hand.
Why even remove a useful feature?
On September 13, 2019 17:00:36 Brian Teeman notifications@github.com wrote:
basically yes. although its useful when building a site locally its
something that is pretty unique to joomla iirc
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26273.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-15 17:37:56 |
| Closed_By | ⇒ | richard67 |
Many people will actually consider it a problem that joomla can create a new database in the installation and/or you should not be using a database user who has creation rights. But I guess consistency across all databases is good