? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
11 Sep 2019

Pull Request for Issue https://forum.joomla.de/thread/10173-stapelverarbeitung-kopiert-beiträge-doppelt (German)

Summary of Changes

On debugging this issue reported in the forum (germam) I have found out that for some reason chrome and IE run the submit event twice and this page here https://www.the-art-of-web.com/javascript/doublesubmit/ pointed me to try return false; in the onclick handler to stop that from happening. This worked for me.

Testing Instructions

First test

  • Install 3.9.11
  • Login to the backend using chrome or IE 11
  • try to use a batch copy of articles for example
  • apply the patch
  • try again
seccond test
  • install 3.9.11
  • Login to the backend using an browser other than chrome and IE
  • try to use a batch copy of articles for example
  • it should work than expected
  • apply the patch
  • try again
  • it should still work as expected

Expected result

The batch copy only copy it once

Actual result

With chrome and IE the batch copy result into two copys

Documentation Changes Required

none

avatar zero-24 zero-24 - open - 11 Sep 2019
avatar zero-24 zero-24 - change - 11 Sep 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Sep 2019
Category Administration com_banners com_categories com_contact com_content com_fields com_menus com_modules com_newsfeeds com_redirect com_tags com_users
avatar franz-wohlkoenig franz-wohlkoenig - change - 12 Sep 2019
Title
Batch copy dublicate in chrome and IE as the submit event is triggerd twce
Batch copy dublicate in chrome and IE as the submit event is triggerd twice
avatar franz-wohlkoenig franz-wohlkoenig - edited - 12 Sep 2019
avatar Harmageddon Harmageddon - test_item - 12 Sep 2019 - Tested successfully
avatar Harmageddon
Harmageddon - comment - 12 Sep 2019

I have tested this item successfully on c1a9c06

Tested in Chromium 76 (Manjaro Linux) in the following views:

  • Banners
  • Categories (Banners)
  • Contacts
  • Articles
  • Fields
  • Field Groups
  • Menu Items
  • Modules
  • Newsfeeds
  • Redirects
  • Tags
  • Users

I can confirm that the problem existed before applying this patch and has been fixed after.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26267.

avatar viocassel viocassel - test_item - 12 Sep 2019 - Tested successfully
avatar viocassel
viocassel - comment - 12 Sep 2019

I have tested this item successfully on c1a9c06


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26267.

avatar franz-wohlkoenig franz-wohlkoenig - change - 12 Sep 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Sep 2019

Status "Ready To Commit".

avatar infograf768 infograf768 - change - 13 Sep 2019
Labels Added: ? ?
avatar infograf768 infograf768 - change - 13 Sep 2019
Title
Batch copy dublicate in chrome and IE as the submit event is triggerd twice
Batch copy duplicate in chrome and IE as the submit event is triggerd twice
avatar infograf768 infograf768 - edited - 13 Sep 2019
avatar HLeithner HLeithner - change - 13 Sep 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-09-13 07:44:18
Closed_By HLeithner
avatar HLeithner HLeithner - close - 13 Sep 2019
avatar HLeithner HLeithner - merge - 13 Sep 2019
avatar HLeithner
HLeithner - comment - 13 Sep 2019

Thanks for fixing ie bugs.

avatar simbus82
simbus82 - comment - 13 Sep 2019

I thought I was crazy when I saw my colleagues duplicate the content "twice" using the "batch" ... I didn't imagine it was a bug!
The problem was with Chrome.
Thanks a lot guys!

avatar zero-24
zero-24 - comment - 13 Sep 2019

Thanks for fixing ie bugs.

In this case also a issue that came up in chrome :D

Add a Comment

Login with GitHub to post a comment