Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#26252] - [4.0] Taking off CPanel Toolbar Icons from language strings for core Dashboards

? ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
10 Sep 2019

Pull Request for Issue #26217

Summary of Changes

Hard coding icons class values for CPanel Icons and deleting the afferent language strings.
It does not destroy the capacity for 3pd to use the feature for custom dashboards with lang strings.

Adding COM_CPANEL_DASHBOARD_PRIVACY_TITLE="Privacy Dashboard" as it was missing from ini file.

Testing Instructions

Display various core CPanel dashboards and verify that the Toolbar Icons are present.

PLT: please take a decision on this as adding classes values in language strings, at least for core, is not a good idea.

@wilsonge @HLeithner

avatar infograf768 infograf768 - open - 10 Sep 2019
avatar infograf768 infograf768 - change - 10 Sep 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Sep 2019
Category ⇒ Administration com_cpanel Language & Strings
avatar brianteeman
brianteeman - comment - 10 Sep 2019

Can you add an icon for the Help page - beforw this PR it used incorrectly the home icon. after this PR it is empty

otherwise all good

avatar Hackwar
Hackwar - comment - 10 Sep 2019

As I explained in the chat, I'm against adding this. This is yet another special case for core, which third party developers have no access to and in the past we had a fantastic track record of breaking stuff that we didn't have in core. Don't introduce special treatment for the core components.

avatar brianteeman
brianteeman - comment - 10 Sep 2019

Don't introduce special treatment for the core components.

agreed

BUT putting css as a language string is worse - translators have a great track record of translating everything

avatar infograf768 infograf768 - change - 10 Sep 2019
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 10 Sep 2019

help icon added
Screen Shot 2019-09-10 at 12 35 24

avatar brianteeman brianteeman - test_item - 10 Sep 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 10 Sep 2019

I have tested this item ✅ successfully on b854c88

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26252.

avatar Quy Quy - test_item - 5 Oct 2019 - Tested successfully
avatar Quy
Quy - comment - 5 Oct 2019

I have tested this item ✅ successfully on c85bf2f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26252.

avatar Quy Quy - change - 5 Oct 2019
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 5 Oct 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26252.

avatar infograf768 infograf768 - change - 6 Oct 2019
Labels Added: ?
avatar shraddhaSankpal27 shraddhaSankpal27 - test_item - 19 Oct 2019 - Tested successfully
avatar shraddhaSankpal27
shraddhaSankpal27 - comment - 19 Oct 2019

I have tested this item ✅ successfully on bf83031

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26252.

avatar wilsonge wilsonge - change - 19 Oct 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-10-19 13:26:11
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 19 Oct 2019
avatar wilsonge wilsonge - merge - 19 Oct 2019
avatar wilsonge
wilsonge - comment - 19 Oct 2019

Thanks!

Add a Comment

Login with GitHub to post a comment