[#26245] - [4.0] Submenu items not modules
- Closed
- 15 Oct 2019
- Medium
- Build: 4.0-dev
- # 26245
- Diff
- SharkyKZ:j4/Submenu
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25993.
Summary of Changes
This removes incorrectly place module action icon from mod_submenu and other code mistaking submenu items for modules.
Testing Instructions
View System Dashboard.
Expected result
Still works but no more misleading module action next to submenu items.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
| Labels |
Added:
?
|
||
Module action buttons belong in the chrome, not in module layout. System Dashboard module is using none chrome which doesn't have action buttons.
Still applies. Use a different chrome. I know the layout is broken when using different chromes but that's out of scope of this PR.
Still applies. Use a different chrome. I know the layout is broken when using different chromes but that's out of scope of this PR.
In this case it is in scope as its not possible to see if the changes work
This removes module action buttons from items that aren't modules.
Sorry for my confusion then on the previous post
I do not get any conflict here. Looks like drone is dead though.
| Labels |
Added:
Conflicting Files
|
||
| Labels |
Removed:
Conflicting Files
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26245.
This kills the Drone
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-15 08:27:04 |
| Closed_By | ⇒ | SharkyKZ |
Tested
The problem here is that we can't edit the "real" module anymore as the cog is no more present for default presets.
I also failed solving this to get a unique cog there and not in child.
It works though when we create a submenu, even with a preset
Examples:
Default Content Dashboard
Modified Component Dashboard (Title set to Show)
