Feeling Lucky
?
[#26243] - [4.0] Fix error with database alias functions
- Fixed in Code Base
- 10 Sep 2019
- Medium
- Build: 4.0-dev
- # 26243
- Diff
- brianteeman:leeds12
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
#26223 by @SharkyKZ and merged (without tests) by @wilsonge introduced at least one error
Testing Instructions
administrator/index.php?option=com_finder&view=maps
Expected result
list of maps
Actual result
syntax error in the query
Summary
The original query was
$query->select([$query->qn('b.id', 'branch_id'), $query->qn('b.title', 'branch_title')])
->leftJoin($query->qn('#__finder_taxonomy', 'b') . ' ON b.level = 1 AND b.lft <= a.lft AND a.rgt <= b.rgt');
This was changed to
$query->select([$db->quote('b.id', 'branch_id'), $db->quote('b.title', 'branch_title')])
->leftJoin($db->quote('#__finder_taxonomy', 'b') . ' ON b.level = 1 AND b.lft <= a.lft AND a.rgt <= b.rgt');
Which is obviously incorrect as qn==> quoteName not quote
This PR fixes that
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-09-10 12:14:52 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 10 Sep 2019
Thanks!
brianteeman
- comment
- 10 Sep 2019
Thanks
I have tested this item✅ successfully on 38ed7e5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26243.