? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
9 Sep 2019

Pull Request for Issue #.

Summary of Changes

Removes IE11 support from the module grid layout classes added in #18516

Testing Instructions

Apply this patch and run node build.js --compile-css for updating the changed SCSS. Alternatively, you can run npm i.

Check that #18516 still functions correctly

avatar ciar4n ciar4n - open - 9 Sep 2019
avatar ciar4n ciar4n - change - 9 Sep 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Sep 2019
Category Front End Templates (site)
avatar brianteeman
brianteeman - comment - 9 Sep 2019

@wilsonge i thought you said we should keep ie11 stuff for the frontend

avatar ciar4n ciar4n - change - 9 Sep 2019
Title
Remove IE11 support from module layout classes
[4.0][Cassiopeia] Remove IE11 support from module layout classes
avatar ciar4n ciar4n - edited - 9 Sep 2019
avatar ciar4n ciar4n - change - 9 Sep 2019
The description was changed
avatar ciar4n ciar4n - edited - 9 Sep 2019
avatar N6REJ
N6REJ - comment - 9 Sep 2019

we now have several pr's for the same issue(s) lol
#26242 #26230 #26231

avatar ciar4n
ciar4n - comment - 9 Sep 2019

That is why we ask for descriptive titles ?

avatar ciar4n ciar4n - change - 9 Sep 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-09-09 21:08:47
Closed_By ciar4n
Labels Added: ?
avatar ciar4n ciar4n - close - 9 Sep 2019
avatar wilsonge
wilsonge - comment - 10 Sep 2019

IE11 stuff is fine to remove in this context. We want to make it easy for frontend templates to add support for html5 so I said keep the es5 files bundled with core. So a template doesn’t have to regenerate them all per release for all extensions.

avatar brianteeman
brianteeman - comment - 10 Sep 2019

Thanks for the clarification

Add a Comment

Login with GitHub to post a comment