[#26228] - [4.0] Cassiopeia header-shadow hiding banner position
- Closed
- 19 Jan 2020
- Medium
- Build: staging
- # 26228
Steps to reproduce the issue
1: create a custom module with some content and assign it to banner position, or
2: create a banner component and banner module and assign it to the banner position
Expected result
Completely visible banner module
Actual result
- Custom modules assigned to the banner position are overlayed with a grey shadow and also the wavy cut-out:
with the shadow removed (using FF inspector) it looks like this:
And with .header-shape-bottom removed it looks like this:
Which is probably how it should look.
- A banner component in a banner module does not display at all. All you see is the header shadow, no banner content and a large 3em margin:
Although there are two classes added, i.e. <div class="mod-banners bannergroup"> those classes are empty as they do not exist in the css.
What purpose does the .header-shadow serve? It is only applied to the container-banner. Why would you want to cover up a banner with a shadow? The code is here:
joomla-cms/templates/cassiopeia/scss/blocks/_header.scss
Lines 164 to 180 in 27e4d28
As well as the shadow and the wavy line, there must be several other pieces of code that are interfering with the display of banners as seems also to have a height of 0 which is coming from somewhere.
System information (as much as possible)
Alpha12Dev nightly update 09.09.19
Additional comments
| Labels |
Added:
?
|
||
franz-wohlkoenig
- | Labels |
Added:
J4 Issue
|
||
| Status | New | ⇒ | Discussion |
...not an advertisement banner as you would get with the banners component.
So there are, in fact, two issues here:
- Anything placed in the banner module position is overlayed by an unnecessary semi-transparent grey div and also the curvy Cassiopeia cut-out.
- A banner component placed in another position, e.g. top-a, still does not show anything. Could it be that there is a chrome missing?
and
3. If the banner module position is just a 'hero' position, then it should be called something else - 'Promo', for instance - so as not to confuse anyone wanting to use the banner component.
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-19 11:49:19 |
| Closed_By | ⇒ | joomla-cms-bot |
| Closed_By | joomla-cms-bot | ⇒ | alikon |
Set to "closed" on behalf of @alikon by The JTracker Application at issues.joomla.org/joomla-cms/26228
closing as we have a pr
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26228.
It sounds like that spot is meant to be a hero image type deal, not an advertisement banner as you would get with the banners component.