Feeling Lucky
?
[#26225] - [4.0] onContentPrepare to return void
- Fixed in Code Base
- 11 Sep 2019
- Medium
- Build: 4.0-dev
- # 26225
- Diff
- SharkyKZ:j4/onContentPrepare
- Success Hound No violations found. Woof! Details
- Pending continuous-integration/drone/pr Build is running Details
User tests: Successful: Unsuccessful:
Summary of Changes
onContentPrepare should return void.
Testing Instructions
Code review.
Documentation Changes Required
Maybe remove reference to boolean here https://docs.joomla.org/Plugin/Events/Content#Return_Value.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-09-11 04:26:54 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 11 Sep 2019
Thanks!
I couldn't find these return values being used in j3 either and we're never returning false. So I think this is all good