Agree. See $keyIcon = $prefix . $sectionkey . '_ICON'; and
$icon = Text::_($keyIcon);

@chmst
As you introduced this in the new backend template, can you figure another way?
b04e550#diff-038a8497dd9ef101525de218e0877ae9

I agree that this is bad. But have no idea how to resolve this.
The icon for the dashboard is not stored in the database, in this view we have the name of the component here, nothing else.

@Hackwar can you help here?

If I understand well, the only reason why it is not harcoded is because it was desired that 3pds be able to create custom Presets where the heading of the custom CPanel dashboard would fit a specific non-core extension.
Taking into account all the issues we have with this new feature and mod_submenu, I suggest this part of the new admin template to be refactored.

I am quite confused by the code in this file.
In which cases can we get $parts[1] from $parts = explode('.', $extension); ?

After clarification, i.e. what kind of custom dashboard/presets (i.e. non-core ones) for which we need all that code instead of simply hardcoding $icon value depending on the default possible core dashboards, we could simplify the file and get rid of the lang strings for $icon.

As much as I dont like hard coding anything - with the current code base that's the only option I can see to handle this.

Note:
2 strings missing if we do not change this code.

COM_CPANEL_DASHBOARD_PRIVACY_TITLE="Privacy Dashboard"
COM_CPANEL_DASHBOARD_PRIVACY_ICON="lock"

As much as I dont like hard coding anything - with the current code base that's the only option I can see to handle this.

The icon is always used for ToolbarHelper::title
So it is not as if we were hardcoding it specially for this case.
Example for articles manager where $icon is stack article:
ToolbarHelper::title(Text::_('COM_CONTENT_ARTICLES_TITLE'), 'stack article');

Bugsquad discussion:
@Hackwar is against any change, including setting a different behavior (hard coding $icon) for core.
The feature is supposed to cope with specific dashboards created by 3pd.

Then the code needs to be improved to be able to work without using a language string to set a class

Can this be used

I made a PR hardcoding icons as this is specific to Toolbarhelper::title()
PLT will decide.

See: #26252

Closed as having Pull Request #26252