[#26210] - [4.0] left sidebar align
- Fixed in Code Base
- 19 Oct 2019
- Medium
- Build: 4.0-dev
- # 26210
- Diff
- astridx:cassiopeia-align
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #26201.
Summary of Changes
No margin for sidebar left.
Testing Instructions
- Apply this patch and run
node build.js --compile-cssfor updating the changedscssfile. Alternatively you can runnpm i. - Add a module to the left sidebar.
- Open the side in the front end and see, that the Cassiopeia sidebars and component area horizontally aligned.
Expected result
Cassiopeia sidebars and component area horizontally aligned.
Actual result
Cassiopeia sidebars and component area not horizontally aligned.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
| Labels |
Added:
?
|
||
@Scrabble96 You are right. I added the missing class now.
@astridx As I don't know about npm /node, I tried as follows:
Changed in template.css (line 12349) from the file: a236fc6 accordingly.
But I think there is missing after: margin-bottom:20px; } Because the: + div becomes:red instead green. So, I added the missing }
Unfortunately still Actual Result. Also I don't know how to compile it to scss file. Sorry.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210.
franz-wohlkoenig
- | Title |
|
||||||
@ChristineWk Thank you for trying to test. If you like to make you familiar with the environment this is a good entry for windows users: https://www.wicked-software.de/joomla-v4-0-win10-composer-and-npm
Hi Astrid,
Thanks for adding commits. After activating under Options CI Server Settings > Switch CI Integration > ON unfortenately (still):
The patch could not be applied either due to missing connection to the server or missing patch on the server.
rgds Christine
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210.
Hi Astrid,
Thanks for adding commits. After activating under Options CI Server Settings > Switch CI Integration > ON unfortenately (still):
The patch could not be applied either due to missing connection to the server or missing patch on the server.
rgds Christine
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210.
The reason for might be:
"This branch is out-of-date with the base branch ..."
No that would not be the issue
Thank you for info. What is the issue for? Maybe: "Some checks were not successful. Build is failing ...."
If you think there is no way, then I would have to stop the activities in this regard.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210.
I have tested this item
Cassiopeia sidebars and component area not horizontally aligned.
When a module is present at sidebar-left position, the margin-top: 15px applies to it.
And, when there is no sidebar-left position, the margin-top: 15px applies to the component area,
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210.
without patch
patch applied
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210.
I have tested this item
After test sidebar is nicely aligned. Thanks @astridx
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26210.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-19 22:53:29 |
| Closed_By | ⇒ | wilsonge |
Thanks!
Thank you :-)
This PR needs to include no top margin for the container-component as well. As I said in my issue #26201, if there is no left sidebar but there is a right sidebar, then the margin is applied to the component area and the right sidebar appears higher than the component (at least it does on larger screens; on the smallest screens both left and right sidebars drop down below the component area.)