[#26204] - [4.0] Set breadcrumb on start of container
- Fixed in Code Base
- 19 Oct 2019
- Medium
- Build: 4.0-dev
- # 26204
- Diff
- astridx:breadcrumbs
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # #26195
Summary of Changes
I changed the positioning of the breadcrumbs.
Testing Instructions
Apply this patch an open the side in the front end. The breadcrumbs are now in front of the content.
Expected result
The breadcrumbs are in front of the content.
Actual result
The breadcrumbs are under the content.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
The if conditionals aren’t saving much here. It just stops the jdoc tag from being in the content buffer when the API does the pass for finding those tags and triggering the right renderer (which IIRC the modules renderer makes the same check). If there were some kind of wrapping markup then the if conditionals make more sense, otherwise at best you’re saving 1-2 nanoseconds and a few bytes of memory at best wrapping undecorated jdoc tags.
franz-wohlkoenig
- | Title |
|
||||||
| Labels |
Added:
?
|
||
@brianteeman @mbabker
The two points for me OK, too.
The main thing is the breadcrumbs are higher up.
Now it loos like this
If the breadcrumbs code is removed from the component container and then this code (with an appropriate new container type, but for a quick test on an installed site, using top-a works as long as there is no other top-a module in place) is inserted just below the top-b position in index.php then it works fine:
<div class="grid-child container-breadcrumbs"> ('breadcrumbs' doesn't yet exist, so use 'top-a')
<jdoc:include type="modules" name="breadcrumbs" style="none" />
</div>
@Scrabble96 If I understand you correctly, you would like to completely reposition the breadcrumbs. right?
@brianteeman How do you like the suggestion?
Not great for me as it's too far from the content if you have big top modules. But I'm not a designer and I build few sites and would just move it on any site I built
Not great for me as it's too far from the content if you have big top modules. But I'm not a designer and I build few sites and would just move it on any site I built
I hadn't realised, but for some reason I don't quite understand, the top-a, top-b and both sidebars drop underneath the content area when viewed on a very small screen, so yes, with my suggestion, the breadcrumbs would drop below the content, too.
I had assumed (silly, I know) that top-a and top-b were designed to be at the top and stay at the top.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26204.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26204.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26204.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-19 09:35:07 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
thx
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26204.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26204.
Personally I would have moved it to be directly above the component
and why is there the if statement? If it is needed then surely it would be needed on all the modules