[#2620] - Test using assertXmlStringEqualsXmlString instead of simple string comparison
- Closed
- 6 Dec 2013
- Medium
- Build: master
- # 2620
- Diff
- okonomiyaki3000:fix_travis
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
I noticed a silly error in the Travis tests. This should fix it. Instead of directly comparing two strings, we can compare two XmlStrings so that insignificant differences in xml structure will not cause a failure.
Ah! Maybe that fixed it then but I think it's not really a complete fix. assertXmlStringEqualsXmlString is the test we should be using here. Then differences like <node /> vs <node></node> will be irrelevant.
From what I understand you are correct.
Could you update your PR to remove the changes made in the other commit then? Because we don't need both.
And it's not a fix anymore but an improvement since currently neither Travis nor Jenkins does fail.
So you should adjust your working and especially the testing instructions in the tracker.
Sure, I'll do that but it'll need to wait till next week. Already Friday night here.
No problem. It's not a pressing issue 
This looks very good 
Could you also fix this for the framework please.. Ref.: joomla/joomla-framework#286
| Labels |
Added:
?
?
?
|
||
infograf768
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2013-12-06 08:14:17 |
Tracker http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32845&start=0