Feeling Lucky
?
[#26196] - Handle non-existing manifest XML files in update sites
- Fixed in Code Base
- 23 Apr 2020
- Medium
- Build: 4.0-dev
- # 26196
- Diff
- roland-d:feature/handle-missing-xml-files
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
If an extension is still in the system but the manifest file is gone a warning is thrown.
Testing Instructions
- Go to the filesystem folder
/administrator/manifests/packages/ - Rename the file
pkg_en-GB.xmltopkg_en-GB.xxml - Login to Joomla backend
- Click on System
- Click on Global Configuration
- Click on the Server Tab
- Make sure Error Reporting is set to Development
- Save & Close the changes
- Click on System
- Click on Update -> Update Sites
- Notice the warning
- Apply the patch
- Reload the page
- Warning is gone
Expected result
No warning message
Actual result
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 28 Sep 2019
Everything here treats the property that comes back as an object in \Joomla\Component\Installer\Administrator\Model\DatabaseModel. Something somewhere is going to blow up somewhere. Understand from @zero-24 's comment that this is possible anyhow in weird circumstances. But then we need to add sanity checks for this giving false in the DatabaseModel alongside this change
vaibhavsTekdi
- comment
- 19 Oct 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26196.
pallaviu
- comment
- 19 Oct 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26196.
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-23 22:13:26 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Removed:
?
|
||
wilsonge
- comment
- 23 Apr 2020
LGTM! Thanks!
I have just suggested an even shorter way ;) But works after the patch.