Feeling Lucky
J4 Issue
?
[#26189] - [4.0] Update sites enabled messages
- Closed
- 6 Sep 2019
- Medium
- Build: staging
- # 26189
Looking at these horrible language strings with their punctuation
joomla-cms/administrator/language/en-GB/en-GB.com_installer.ini
Lines 28 to 29 in 46c892c
They are referenced in the model here
But I dont see this code being used anywhere in the update view
Instead the sites are enabled/disabled in the updatesite view with this code in the controller although the comment refers to extensions not sites
Is this code duplication? Is the comment wrong
@roland-d any ideas?
joomla-cms-bot
- | Labels |
Added:
?
|
||
franz-wohlkoenig
- | Labels |
Added:
J4 Issue
|
||
| Status | New | ⇒ | Discussion |
brianteeman
- comment
- 6 Sep 2019
can you make the pr to make sure I dont miss any of the unused code
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-09-06 15:05:44 |
| Closed_By | ⇒ | roland-d |
@brianteeman According to Github you last changed the language strings as part of PR #5615?
Agree, as far as I can tell this code isn't used anymore and can be removed. As you pointed out, this is now handled by the
publish()function.Will you make the PR or should I?