? ?
avatar brianteeman
brianteeman
5 Sep 2019

The backend template team removed the entire code for checking extension compatibility in the pre-update checker with this PR joomla/backend-template#403 by @chmst

I can't find any explanation or comment about this.

If it was on purpose then it was incomplete as language files and notices referring to it are still present. If confirmed I can com[lete the removal

If it was an error caused due to lack of testing and blind merging then I can put it back while I am updating it for accessibility etc

@wilsonge @bembelimen Please advise

avatar brianteeman brianteeman - open - 5 Sep 2019
avatar joomla-cms-bot joomla-cms-bot - change - 5 Sep 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 5 Sep 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 5 Sep 2019
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 5 Sep 2019
avatar brianteeman
brianteeman - comment - 5 Sep 2019

Assuming it was a mistake I put it back with #26178

Please leave open until it is confirmed

avatar franz-wohlkoenig franz-wohlkoenig - change - 5 Sep 2019
Status New Discussion
avatar bembelimen
bembelimen - comment - 6 Sep 2019

Thx for the finding. Seems that it slipped through independently of having a PR and a enforced review.

avatar brianteeman
brianteeman - comment - 6 Sep 2019

so you can confirm it was an error and my pr to put it back is correct?

avatar wilsonge
wilsonge - comment - 6 Sep 2019

it was an error. pr to put it back is correct

avatar brianteeman
brianteeman - comment - 6 Sep 2019

thanks

avatar brianteeman brianteeman - close - 6 Sep 2019
avatar brianteeman brianteeman - change - 6 Sep 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-09-06 09:36:42
Closed_By brianteeman

Add a Comment

Login with GitHub to post a comment