? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
4 Sep 2019

Pull Request for Issue #25966 .

Summary of Changes

Wrap the button group in a < li

avatar chmst chmst - open - 4 Sep 2019
avatar chmst chmst - change - 4 Sep 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2019
Category Administration Templates (admin) Layout
avatar chmst chmst - change - 4 Sep 2019
Labels Added: ?
avatar brianteeman brianteeman - test_item - 5 Sep 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 5 Sep 2019

I have tested this item successfully on 4b6605a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26167.

avatar brianteeman
brianteeman - comment - 5 Sep 2019

this solves the accessibility issue and the invalid markup - thanks

avatar ChristineWk
ChristineWk - comment - 7 Sep 2019

result of patch/check of html, if it's OK?

screen shot 2019-09-07 at 12 20 33


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26167.

avatar ChristineWk ChristineWk - test_item - 7 Sep 2019 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 7 Sep 2019

I have tested this item successfully on 0c661f2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26167.

avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Sep 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Sep 2019

Status "Ready To Commit". 1 Build is failing.

avatar zero-24
zero-24 - comment - 7 Sep 2019

Should't the comment by @C-Lodder checked before we move this to RTC?

avatar zero-24 zero-24 - change - 7 Sep 2019
Status Ready to Commit Pending
avatar chmst
chmst - comment - 7 Sep 2019

Thank you @C-Lodder for the hint.

avatar C-Lodder
C-Lodder - comment - 8 Sep 2019

The CSS is still there. It can be removed

avatar wilsonge wilsonge - change - 28 Sep 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-09-28 02:31:49
Closed_By wilsonge
avatar wilsonge wilsonge - close - 28 Sep 2019
avatar wilsonge wilsonge - merge - 28 Sep 2019
avatar wilsonge
wilsonge - comment - 28 Sep 2019

Thanks!

Add a Comment

Login with GitHub to post a comment