? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
2 Sep 2019

This PR corrects lots of different errors in the table for assigning modules to your menu item.

Removes ID from table cells
Adds caption to table
Adds ID to table
Adds scope to cols and rows
Moves column width style from every cell in every row to just the thead
Removes the inline style text-center from every cell in every row - text should be left aligned in columns

Note the link to edit a module is not working and is beyond the scope of this PR see #26146

avatar brianteeman brianteeman - open - 2 Sep 2019
avatar brianteeman brianteeman - change - 2 Sep 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Sep 2019
Category Administration com_menus
680ebb6 2 Sep 2019 avatar brianteeman th
avatar brianteeman brianteeman - change - 2 Sep 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 3 Sep 2019
Category Administration com_menus Administration com_menus Language & Strings
avatar brianteeman brianteeman - change - 3 Sep 2019
Labels Added: ?
avatar Quy Quy - test_item - 3 Sep 2019 - Tested successfully
avatar Quy
Quy - comment - 3 Sep 2019

I have tested this item successfully on f2684ef


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26147.

avatar brianteeman brianteeman - change - 30 Nov 2019
Labels Added: Conflicting Files
avatar brianteeman
brianteeman - comment - 30 Nov 2019

conflicts resolved

avatar Fedik Fedik - test_item - 20 Jan 2020 - Tested successfully
avatar Fedik
Fedik - comment - 20 Jan 2020

I have tested this item successfully on 0246346


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26147.

avatar Quy Quy - change - 20 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 20 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26147.

avatar Quy Quy - change - 20 Jan 2020
Labels Added: ?
avatar wilsonge wilsonge - change - 21 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-21 11:51:20
Closed_By wilsonge
Labels Removed: Conflicting Files
avatar wilsonge wilsonge - close - 21 Jan 2020
avatar wilsonge wilsonge - merge - 21 Jan 2020
avatar wilsonge
wilsonge - comment - 21 Jan 2020

Thanks!

avatar brianteeman
brianteeman - comment - 21 Jan 2020

thanks

Add a Comment

Login with GitHub to post a comment