? Error

User tests: Successful: Unsuccessful:

avatar zero-24 zero-24 - open - 28 Nov 2013
avatar zero-24 zero-24 - change - 28 Nov 2013
Labels Added: ?
avatar zero-24
zero-24 - comment - 28 Nov 2013

done

avatar zero-24
zero-24 - comment - 28 Nov 2013
avatar zero-24
zero-24 - comment - 28 Nov 2013

so this shoud work now :)

avatar Bakual
Bakual - comment - 28 Nov 2013

It works for 3rd party extensions as long as they have the language string in their files. I've commented in code to show a solution in case the string isn't present. Maybe someone knows an even better one.

Also to consider: I would use a language key which is consistent with the other keys in the file. So something like strtoupper('PLG_FINDER_' . $type->element . '_TYPE_' . str_replace(' ', '_', $type->type_title)') which would hopefully result in PLG_FINDER_CONTENT_TYPE_ARTICLE

avatar zero-24
zero-24 - comment - 28 Nov 2013

@Bakual

strtoupper('PLG_FINDER_' . $type->element . 'TYPE' . str_replace(' ', '', $type->typetitle)')

or
strtoupper('PLG_FINDER_' . $type->element . 'TYPE' . str_replace(' ', '', $type->typetitle))

or

strtoupper('PLG_FINDER_' . $type->element . 'TYPE' . str_replace(' ', '', $type->typetitle)'')

what is better? The first looks not right (not closed) or i'm wrong?

EDIT:
@Bakual

I've commented in code to show a solution in case the string isn't present.

merged

avatar Bakual
Bakual - comment - 28 Nov 2013

Aye, my line was wrong. The ' at the end slipped in due to copy-pasting.
strtoupper('PLG_FINDER_' . $type->element . '_TYPE_' . str_replace(' ', '_', $type->type_title))
should be better (didn't test it).

avatar zero-24
zero-24 - comment - 28 Nov 2013

@Bakual
We must add a ";" after it. Than it show this error
Notice: Undefined property: stdClass::$element in I:\Server_new\htdocs\git\administrator\components\com_finder\views\statistics\tmpl\default.php on line 35

avatar Bakual
Bakual - comment - 28 Nov 2013

@zero-24 I had a closer look at the data. Unfortunately my idea doesn't work out as the element isn't even stored anywhere. We would have to use the plugin name for that, but that is just crappy code then.
So better leave it with the current language key. It will work :smiley:

avatar zero-24
zero-24 - comment - 29 Nov 2013

ok thanks @Bakual
so we need min. two good tests for this patch.

avatar zero-24 zero-24 - change - 3 Dec 2013
Labels Added: ?
avatar MAT978
MAT978 - comment - 5 Feb 2014

@test
Able to reproduce then #2613 works as expected and following Thomas also with 3rd party extensions.
Set RTC on the Tracker
Thanks

avatar mbabker mbabker - change - 17 Feb 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-02-17 04:22:05
avatar mbabker mbabker - close - 17 Feb 2014

Add a Comment

Login with GitHub to post a comment