? ? Pending

User tests: Successful: 0 Unsuccessful: 0

avatar brianteeman
brianteeman
1 Sep 2019

Removes the redundant word "show" from the language strings. It's a select field so we can assume it means show. We don't say "show" anywhere else

before

image

after

image

avatar brianteeman brianteeman - open - 1 Sep 2019
avatar brianteeman brianteeman - change - 1 Sep 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Sep 2019
Category Administration Language & Strings
avatar Quy
Quy - comment - 2 Sep 2019

For the Featured select type, Articles is proper case. Should extensions be too?

- Select Featured - 
Unfeatured Articles 
Featured Articles
avatar brianteeman brianteeman - change - 2 Sep 2019
Labels Added: ? ?
avatar Quy Quy - test_item - 2 Sep 2019 - Tested successfully
avatar Quy
Quy - comment - 2 Sep 2019

I have tested this item successfully on 75ad478


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26126.

avatar HLeithner
HLeithner - comment - 2 Sep 2019

Is "- select core -" correct ? shouldn't it be somthing like "select type"? At least I wouldn't understand out of context what "select core" means.

avatar brianteeman
brianteeman - comment - 2 Sep 2019

I wasn't happy with it either but I don't think type is any better and I can't think of anything better

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Sep 2019

– Select Extensions –
Core extensions
Non-core extensions

avatar brianteeman
brianteeman - comment - 2 Sep 2019

I will go with @franz-wohlkoenig suggestion and then hopefully this can be merged

avatar HLeithner
HLeithner - comment - 2 Sep 2019

Still not perfect but better then "core". Thanks.

avatar HLeithner HLeithner - change - 2 Sep 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-09-02 10:48:06
Closed_By HLeithner
avatar HLeithner HLeithner - close - 2 Sep 2019
avatar HLeithner HLeithner - merge - 2 Sep 2019
avatar brianteeman
brianteeman - comment - 2 Sep 2019

small steps

thanks for merging

Add a Comment

Login with GitHub to post a comment