? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
1 Sep 2019

The colour used for the warnings is far too close to the error colour.

warning

image

error

image

This PR changes it back to the yellow colour bootstrap intended and changes the text to black from white to satisfy accessibility - just as bootstrap does

And it is pretty weird to have a variable called yellow being a dark orange ;)

Pull Request for Issue #25911

Testing Instructions

Apply PR and then npm i

on a non multilingual site visit the multilingual associations page

Before

image

After

image

and the information warnings page

Before

image

After

image

avatar brianteeman brianteeman - open - 1 Sep 2019
avatar brianteeman brianteeman - change - 1 Sep 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Sep 2019
Category Administration Templates (admin)
avatar Quy Quy - test_item - 2 Sep 2019 - Tested successfully
avatar Quy
Quy - comment - 2 Sep 2019

I have tested this item successfully on f7070f1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26124.

avatar wilsonge wilsonge - change - 2 Sep 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 2 Sep 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-09-02 11:05:52
Closed_By wilsonge
avatar wilsonge wilsonge - close - 2 Sep 2019
avatar wilsonge wilsonge - merge - 2 Sep 2019
avatar wilsonge
wilsonge - comment - 2 Sep 2019

Thanks!

avatar brianteeman
brianteeman - comment - 2 Sep 2019

thanks - my eyes wont hurt anymore

Add a Comment

Login with GitHub to post a comment