? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
1 Sep 2019

Summary of Changes

Now that #26067 has been merged, we can update the alternate preset menu Preset - Alternative Main Menu

This separates the Home Dashboard from System to add it as first Menu item.
It moves the Media menu below the Content menu.
It corrects the redundant Workflows menu item from Content.

Testing Instructions

Edit the default Administrator Menu module and choose Preset - Alternative Main Menu

Before patch

Home dashboard is a sub of System
Media comes above Content
Workflows menu item is added twice in Content menu

After patch

Screen Shot 2019-09-01 at 09 27 30

@chmst @ChristineWk

avatar infograf768 infograf768 - open - 1 Sep 2019
avatar infograf768 infograf768 - change - 1 Sep 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Sep 2019
Category Administration com_menus
avatar brianteeman brianteeman - test_item - 1 Sep 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 1 Sep 2019

I have tested this item successfully on f681118


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26115.

avatar brianteeman
brianteeman - comment - 1 Sep 2019

I have marked it as a success because it does what it says.

BUT it has several issues

  1. how are you going to provide access to some of the core components that are not in the menu db table such as post installation messages
  2. any menu item that has an add new is no longer a link eg there are no links to the list of all articles menus
    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26115.
avatar brianteeman
brianteeman - comment - 1 Sep 2019

I have marked it as a success because it does what it says.

BUT it has several issues

  1. how are you going to provide access to some of the core components that are not in the menu db table such as post installation messages
  2. any menu item that has an add new is no longer a link eg there are no links to the list of all articles
    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26115.
avatar chmst
chmst - comment - 1 Sep 2019

@brianteeman agree completely with you.
I did the renaming because we had the presets since a long time and I always had this feeling "This here is modern, so Joomla ist the old-fashined one" .
But now the alternate preset must be made with care and give good alternative. This was not in scope.

avatar brianteeman
brianteeman - comment - 1 Sep 2019

I'm not sure if with the changes made to make the menus for the template if it's going to be possible

avatar infograf768
infograf768 - comment - 1 Sep 2019

This is a part 1 of the alternate preset.
I am now looking at the remaining issues.

avatar brianteeman
brianteeman - comment - 1 Sep 2019

Good luck with that

avatar infograf768
infograf768 - comment - 1 Sep 2019

how are you going to provide access to some of the core components that are not in the menu db table such as post installation messages

I can get them eaasily as well as J update.
Screen Shot 2019-09-01 at 16 32 10

any menu item that has an add new is no longer a link eg there are no links to the list of all menus

Not sure I understand this one.
List of all menus as well as all menu items is already present and one can add new for Menus.

Can you point to me the items that really need to be looked at.

avatar infograf768
infograf768 - comment - 1 Sep 2019

We can also add back where necessary what was deleted by someone in J4.
For example below for New user
Old way
Screen Shot 2019-09-01 at 17 05 03

or with a quicktask
Screen Shot 2019-09-01 at 17 09 39

avatar infograf768
infograf768 - comment - 1 Sep 2019

@chmst
Please add your test OK so that we get it merged and I go on improving this alternate.

avatar brianteeman
brianteeman - comment - 1 Sep 2019

Can you point to me the items that really need to be looked at.

Not at my PC but from memory it was not possible to list all menus.

avatar infograf768
infograf768 - comment - 1 Sep 2019

Not at my PC but from memory it was not possible to list all menus.

It does already list all menus as is.

avatar brianteeman
brianteeman - comment - 1 Sep 2019

It does already list all menus as is.

Not menu items - menus
index.php?option=com_menus&view=menus

avatar infograf768
infograf768 - comment - 2 Sep 2019

Understood now what you mean.
Will add quicktasks for all places where necessary in Part2 as soon as this one is merged.

avatar infograf768 infograf768 - change - 2 Sep 2019
Labels Added: ?
avatar infograf768
infograf768 - comment - 2 Sep 2019

Decided to complete the alternate instead of waiting for another PR.
It should now provide all possible navigation.
@chmst @brianteeman

please test again

fa2f003 2 Sep 2019 avatar infograf768 oops
avatar brianteeman
brianteeman - comment - 2 Sep 2019

Removing the add new to the menus solved that problem

I now see an issue with the selected menu not being highlighted (and or expanded) when you open a link from the dashboard eg thw templates quickicon


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26115.
avatar brianteeman
brianteeman - comment - 2 Sep 2019

Removing the add new to the menus solved that problem

I now see an issue with the selected menu not being highlighted (and or expanded) when you open a link from the dashboard eg thw templates quickicon


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26115.
avatar infograf768
infograf768 - comment - 2 Sep 2019

I now see an issue with the selected menu not being highlighted (and or expanded) when you open a link from the dashboard eg thw templates quickicon

Looks OK here:
template

Works also fine for Joomlaupdate etc.

avatar infograf768
infograf768 - comment - 2 Sep 2019

If you speak about the Templates in the Site submenu module, i.e
Screen Shot 2019-09-02 at 18 35 38

Then you are correct. Issue comes from the url.
The icon uses the client
administrator/index.php?option=com_templates&client_id=0
while the menu item does not.
The issue is easy to solve.
Correcting now.

avatar infograf768
infograf768 - comment - 2 Sep 2019

Changed to use similar urls for Modules and templates styles.

avatar infograf768
infograf768 - comment - 2 Sep 2019

I see that we also have to do something similar for Users and articles categories but the links used for that last one is weird
index.php?option=com_categories
I think it should be
index.php?option=com_categories&extension=com_content

I will try to find out where in code this is used.
EDIT:
It is used in Quickiconhelper. Weird.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Sep 2019
Category Administration com_menus Administration com_menus Modules
avatar infograf768
infograf768 - comment - 3 Sep 2019

Ok, now when clicking a quickicon, the corresponding menu item should be hightlighted/expanded when using the alternate.xml.
I had to correct a totally wrong link for the Quickicon Menu Items and modified the Quickicon Article Categories.

Important Note

I found out that it was also NOT the case when using the default.xml preset as links may be different. Is mostly missing the view in quickicon links.
Therefore, another PR should be done where we make sure that the links are normalized in the 3 cases as this PR does not concern modern.xml:

  • modern.xml
  • alternate.xml
  • QuickiconHelper.php

This can be tested when showing ALL quickicons in the Site quickicon module and testing them one after the other:
Screen Shot 2019-09-03 at 08 29 20

avatar wilsonge wilsonge - change - 3 Sep 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-09-03 10:13:36
Closed_By wilsonge
avatar wilsonge wilsonge - close - 3 Sep 2019
avatar wilsonge wilsonge - merge - 3 Sep 2019
avatar wilsonge
wilsonge - comment - 3 Sep 2019

Thanks!

avatar infograf768
infograf768 - comment - 3 Sep 2019

OK. Will now create another PR to normalise the urls.

Add a Comment

Login with GitHub to post a comment