? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
31 Aug 2019

Pull Request for Issue #24076

Summary of Changes

Modifying order and place Toggle Editor button to top of textarea, next to the other Tiny buttons.
Correcting rtl button display in backend.

Testing Instructions

Apply patch and edit an article with TinyMce in backend and frontend

After patch

LTR
Screen Shot 2019-08-31 at 18 10 12
Screen Shot 2019-08-31 at 18 09 35

RTL
Screen Shot 2019-08-31 at 18 08 30
Screen Shot 2019-08-31 at 18 08 13

avatar infograf768 infograf768 - open - 31 Aug 2019
avatar infograf768 infograf768 - change - 31 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Aug 2019
Category Administration Templates (admin) Layout Front End Plugins
avatar brianteeman
brianteeman - comment - 31 Aug 2019

For me this is too intrusive and with the code button in tinymce now being so good the need has pretty much been removed

avatar C-Lodder
C-Lodder - comment - 31 Aug 2019

Agreed. Critical content should come first...in this case the editor itself

avatar infograf768
infograf768 - comment - 31 Aug 2019

When reducing the screen width, the code button in TinyMCE can be anywhere and becomes hard to find with default Tiny settings.

Example:
Screen Shot 2019-08-31 at 18 42 33

I thought first that if it was always placed as first button, we could consider dropping the Toggle Editor, but it requires editing Tiny variations and it can become cumbersome (I succeeded after a while).

Also, the Toggle Editor button is always displayed whatever the tiny settings, which is not the case for the code button.

avatar infograf768
infograf768 - comment - 31 Aug 2019

It is true though that it is extremely prominent in back-end, while it is not so much in frontend.
That could be solved by changing the background of the button in back-end and even take off the icon

avatar brianteeman
brianteeman - comment - 31 Aug 2019

You're fixing a problem that doesn't exist

avatar infograf768
infograf768 - comment - 31 Aug 2019

Except that one has to scroll and scroll and there was a good reason #24076 issue was created...

avatar brianteeman
brianteeman - comment - 31 Aug 2019

No scrolling required if you use the tinymce button which is a much better experience than no editor.

Personally I would drop it alltogether

avatar infograf768
infograf768 - comment - 31 Aug 2019

Again read above

Also, the Toggle Editor button is always displayed whatever the tiny settings, which is not the case for the code button.

avatar infograf768
infograf768 - comment - 31 Aug 2019

we could get something like this that would not be so prominent and have a look like tiny buttons
Screen Shot 2019-08-31 at 19 43 17

avatar Quy
Quy - comment - 31 Aug 2019

I guess if you rarely/don't use this feature then it can be intrusive when at the top.
On my monitor, I don't have to scroll much to see it at the bottom.
Another way to access it is under the View menu.

avatar brianteeman
brianteeman - comment - 31 Aug 2019

Again read above

I have and I am still not convinced that this is so important it must be moved to the prime location

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Sep 2019

Source-Code of TinyMCE- and Toggle Editor-Button is the same, no need for the Toggle Editor-Button.

avatar infograf768 infograf768 - change - 1 Sep 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-09-01 05:29:18
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 1 Sep 2019
avatar simbus82
simbus82 - comment - 1 Sep 2019

No, source code of TinyMCE and "Editor OFF" are far two really different things.
When i want to add some code that TinyMCE can "destroy", since 10 years, users of Joomla (real admin users!) are instructed to toggle off the editor and reopen the article/module/other to edit the content without the wrong effect of an wysiwyg editor.
Really you want that any time i want to edit real code i need to go to Global Configuration (or user settings) to disable the editor?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Sep 2019

i meant optical.

Toggle Editor-Button

Bildschirmfoto 2019-09-01 um 12 16 22

TinyMCE-Button

Bildschirmfoto 2019-09-01 um 12 16 37

avatar brianteeman
brianteeman - comment - 1 Sep 2019

@simbus82

  1. This was about moving the button not about removing it
  2. Can you please check with the tinymce code editor and provide an example that does not work. As far as I am aware this new version of tinymce should not have any limitations

Add a Comment

Login with GitHub to post a comment