? ? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
31 Aug 2019

Due to the restructured menu in J4 there was no direct link on the menu or the components dashboard to the list off aall Private Messages

This PR fixes that

avatar brianteeman brianteeman - open - 31 Aug 2019
avatar brianteeman brianteeman - change - 31 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Aug 2019
Category SQL Administration com_admin Postgresql Language & Strings Installation
avatar infograf768
infograf768 - comment - 31 Aug 2019

Thanks. I had noted that issue in #26067 (comment)

I have a problem in PhpMyadmin to apply the Insert from the update sql:
It says
1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' 17, 20, 0, '*', 1, '0000-00-00 00:00:00', '0000-00-00 00:00:00')' at line 1

The error comes from the fact that the params column is missing an empty value by using ''
'class:messages', 0, , 17, 20, 0,
should be
'class:messages', 0, '', 17, 20, 0,

same for postgres update

Once corrected, and I don't know if it is my version of PHPMyadmin or not, I still have an error:
#1292 - Incorrect datetime value: '0000-00-00 00:00:00' for column 'checked_out_time' at row 1

avatar alikon
alikon - comment - 31 Aug 2019

for the datetime issue for postgresql the defualt date time is not 0000-00-00 00:00:00' but 1970-01-01 00:00:00 for mysql phpmyadmin depending on your mysql version and setting the correct datetime should be '1000-01-01 00:00:00' see https://dev.mysql.com/doc/refman/8.0/en/datetime.html for more info

avatar infograf768
infograf768 - comment - 31 Aug 2019

@alikon
You are damned right. Issue with update is solved here using '1000-01-01 00:00:00'
My sql version is Server version: 5.7.25 - MySQL Community

Shall not we correct this all over our sqls? Including joomla.sql ?

avatar alikon
alikon - comment - 31 Aug 2019

No we don't need in joomla for now at least for mysql < 8, cause we are setting the no sql strict mode

mysqli_query($this->connection, "SET @@SESSION.sql_mode = '';");

avatar brianteeman brianteeman - change - 31 Aug 2019
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 31 Aug 2019

should be ok now. it was late when I did this and it sadly was pretty sloppy

avatar alikon
alikon - comment - 31 Aug 2019

my only concern is about the lft,rgt values as the #__menu is one of the nested tables,
but take my comment like as someone reading only the code in hurry , (ie without proof) :smile

avatar brianteeman
brianteeman - comment - 31 Aug 2019

i was concerned too. didnt seem to have a negative impact and i dont know how to fix it without changing all records

avatar brianteeman
brianteeman - comment - 1 Sep 2019

The system test errors reported by drone seem valid to me but are unrelated to this PR

avatar infograf768
infograf768 - comment - 1 Sep 2019

Drone relaunched

avatar wilsonge wilsonge - change - 3 Sep 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-09-03 10:13:12
Closed_By wilsonge
avatar wilsonge wilsonge - close - 3 Sep 2019
avatar wilsonge wilsonge - merge - 3 Sep 2019
avatar wilsonge
wilsonge - comment - 3 Sep 2019

Thanks!

avatar brianteeman
brianteeman - comment - 3 Sep 2019

Thanks

Add a Comment

Login with GitHub to post a comment