J4 Issue ?
avatar Scrabble96
Scrabble96
30 Aug 2019

Steps to reproduce the issue

Create a module in Cassiopeia of the type 'top-b' (or 'bottom-b'; this issue applies to both modules)
Set the title to 'Show'

Expected result

Visible title

Actual result

No title:
Alpha11-module-top-b

System information (as much as possible)

Joomla 4 Alpha 11 full package nightly from 30.08.2019

Additional comments

Index.php shows the code for this module is exactly the same as for the adjacent 'top-a' except for the style, which is 'card', rather than 'cardGrey':

    <?php if ($this->countModules('top-a')) : ?>
	<div class="grid-child container-top-a">
		<jdoc:include type="modules" name="top-a" style="cardGrey" />
	</div>
	<?php endif; ?>

	<?php if ($this->countModules('top-b')) : ?>
	<div class="grid-child container-top-b">
		<jdoc:include type="modules" name="top-b" style="card" />
	</div>
	<?php endif; ?>

The only difference being that top-a has a grey background. (I'm not sure where "cardGrey" comes from as it is defined as "card-grey" in both the minified and unminified template.css files.)

There are two Chromes for modules which, under the new system, are in html -> layouts -> chromes cardGrey.php and default.php, which differ only that cardGrey.php includes the class card card-grey and the default just `card

There does not appear to be any instruction to say - "do not display the title".
If there is, where is it and how can it be overridden?

avatar Scrabble96 Scrabble96 - open - 30 Aug 2019
avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 30 Aug 2019
avatar Scrabble96 Scrabble96 - change - 30 Aug 2019
Title
[4.0] top-b does not display title
[4.0] top-b and bottom-b do not display title when set to 'Show'
avatar Scrabble96 Scrabble96 - edited - 30 Aug 2019
avatar Scrabble96 Scrabble96 - change - 30 Aug 2019
The description was changed
avatar Scrabble96 Scrabble96 - edited - 30 Aug 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Aug 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 30 Aug 2019
avatar brianteeman
brianteeman - comment - 30 Aug 2019

I'm not sure where "cardGrey" comes from
As you stated in your next line its the name of the chrome - not the same thing as a css class

As for the "card" chrome that looks to me like you found a bug as I see several other chromes that are not defined either eg xhtml

avatar franz-wohlkoenig franz-wohlkoenig - change - 31 Aug 2019
Status New Discussion
avatar ReLater
ReLater - comment - 31 Aug 2019

I see several other chromes that are not defined either eg xhtml

xhtml has been removed in favor of html5 chrome. Sorry, I don't find the pr at the moment.

avatar brianteeman
brianteeman - comment - 31 Aug 2019

yes I know but the template has not been updated

avatar ReLater
ReLater - comment - 31 Aug 2019

Ah, OK. Thanks for clarification.

avatar Scrabble96
Scrabble96 - comment - 1 Sep 2019

Of the current Cassiopeia chromes, both default.php and cardGrey.php, I've noticed some missing code in line 26:

Current code:
<div class="card-body">

Proposed code to allow styling of body section in modules in different positions, particularly for custom modules, but it may well apply to other types, too:

<div class="<?php echo $modulePos; ?> card-body">

I'm happy to raise a PR for this.

avatar Scrabble96
Scrabble96 - comment - 5 Oct 2019

I'm closing the PR but leaving this issue open because, as @brianteeman said earlier, several chromes have not been defined. Consequently, I've changed the title to reflect this.

avatar Scrabble96 Scrabble96 - change - 5 Oct 2019
Title
[4.0] top-b and bottom-b do not display title when set to 'Show'
[4.0] top-b and bottom-b missing chromes so do not display title when set to 'Show'
avatar Scrabble96 Scrabble96 - edited - 5 Oct 2019
avatar Formatio-hippocampi
Formatio-hippocampi - comment - 25 Sep 2020

looks solved:

Screen Shot 2020-09-25 at 13 03 10
Screen Shot 2020-09-25 at 13 04 40

avatar Bakual
Bakual - comment - 25 Sep 2020

Yep, this has been solved with #30729

avatar alikon alikon - change - 25 Sep 2020
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2020-09-25 11:50:41
Closed_By alikon
avatar alikon
alikon - comment - 25 Sep 2020

ok let's close it then

avatar alikon alikon - close - 25 Sep 2020

Add a Comment

Login with GitHub to post a comment