? Failure

User tests: Successful: Unsuccessful:

avatar zero-24 zero-24 - open - 27 Nov 2013
avatar zero-24 zero-24 - change - 27 Nov 2013
Labels Added: ?
avatar chrisdavenport
chrisdavenport - comment - 27 Nov 2013

What happens when a site has custom content types installed? Are the correct language strings loaded from the plugin language files?

avatar Bakual
Bakual - comment - 27 Nov 2013

This does indeed not support 3rd party extensions.
A working solution would be to load all smart search plugin language files (maybe only the .sys.ini ones) and then put the string into those files.

On a sidenote: This PR misses the strings for "News Feed" and "Web Link".

avatar zero-24
zero-24 - comment - 28 Nov 2013

thanks @Bakual
so i close here. But i think it needs work.

A working solution would be to load all smart search plugin language files (maybe only the .sys.ini ones) and then put the string into those files.

hmm sorry i don't know how to do.

avatar zero-24 zero-24 - change - 28 Nov 2013
Status New Closed
Closed_Date 0000-00-00 00:00:00 2013-11-28 08:41:46
Labels Added: ?
avatar zero-24 zero-24 - close - 28 Nov 2013
avatar zero-24 zero-24 - close - 28 Nov 2013
avatar zero-24 zero-24 - head_ref_deleted - 28 Nov 2013
avatar chrisdavenport
chrisdavenport - comment - 28 Nov 2013

The issue should remain open as it still needs fixing, even if this PR does not fix it (entirely).

avatar zero-24
zero-24 - comment - 28 Nov 2013

I have reopen the issue now

avatar Bakual
Bakual - comment - 28 Nov 2013

hmm sorry i don't know how to do.

@zero-24 To get all smart search plugins you probably can use something like JPluginHelper::getPlugin('finder'). I did not test this but from looking at the code this could help I think.
From there loading language files should be quite simple. See http://docs.joomla.org/Loading_extra_language_files

avatar infograf768
infograf768 - comment - 28 Nov 2013

I get this by adding in models/statistics

            $lang       = JFactory::getLanguage();
    $plugins = JPluginHelper::getPlugin('finder');

    foreach ($plugins as $plugin)
    {
            $lang->load('plg_finder_'.$plugin->name.'.sys', JPATH_ADMINISTRATOR, null, false, true)
        ||  $lang->load('plg_finder_'.$plugin->name.'.sys', JPATH_PLUGINS.'/finder/'.$plugin->name, null, false, true);
    }
avatar zero-24
zero-24 - comment - 28 Nov 2013

See: #2613

i don't know that it work?

avatar infograf768
infograf768 - comment - 28 Nov 2013

I simplified the code above

Add a Comment

Login with GitHub to post a comment