User tests: Successful: Unsuccessful:
Pull Request for Issue #26078
Make sure mariadb versions are correctly identified by the updater
pre update checker and install of the update is proposed
In order to make this work this here implements a new version detection for mariadb and also requires mariadb to be specified in the XML. This new behavior needs to be documented.
<supported_databases mysql="5.6" mariadb="10.4" postgresql="11.0"/>
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
?
?
|
@zero-24 My comment here #26104 (comment) applies also to this PR here. Shall I provide fixes for both PRs with making PRs to your repo?
Merged thanks @richard67
Unfortunately I don't use MariaDB, sounds too catholic to me, am protestant ;-) So I can't help with a test.
I tested this with 10.3.16-MariaDB and the updater works again, after adding the patch.
But my MariaDB version is not one of the supported databases. Is this intended?
Btw System Information displays before and after the patch:
Database Type: mysql
Database Version: 5.5.5-10.3.16-MariaDB
I tested this with 10.3.16-MariaDB and the updater works again, after adding the patch.
But my MariaDB version is not one of the supported databases. Is this intended?
It is more an minimum_databases tag ;) As the updates points to 10.1 you are good to go with 10.3.16
Btw System Information displays before and after the patch:
Yes this is intended as 5.5.5.XX.XX.XX is the actual version that the database returns.
@fancyFranci please mark your test as successfully (how to: https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results)
I have tested this item
Catholic enough
I tested this with 10.3.16-MariaDB and the updater works again, after adding the patch.
But my MariaDB version is not one of the supported databases. Is this intended?It is more an minimum_databases tag ;) As the updates points to 10.1 you are good to go with 10.3.16
This is the point that confuses me, as 10.3. is lower than the minimum 10.4., isn't it? :)
I have tested this item
Before applying the patch Joomla said that the update was not available, after applying the patch the update of Joomla 4 shows up.
This is the point that confuses me, as 10.3. is lower than the minimum 10.4., isn't it? :)
The minimum configured on the update server right now is:
<supported_databases mysql="5.6" mariadb="10.0" postgresql="11.0"/>
So anything above that should pass using the testing update server provided above. This is not an official statement on what would be the actual minimum for sure. ;)
Ah ok i now got where the confusion is comming from @fancyFranci it is my fault :D
The update server itself points to mariadb 10.0 in my description here i used 10.4 bis this is not the version set in the xml and should have only represent an example how the xml could look like.
So in conclusion everything works as expected :)
Yes and no :D You are correct this should be the case for 4.0 stable but as of now the update server in this example still points to
<php_minimum>7.0.0</php_minimum>
https://www.jah-tz.de/downloads/core/nightlies/next_major_extension.xml
I'm not at my desk so i can not update it yet but it is totally working than expected for now :)
Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-09-05 12:23:47 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
?
|
Thanks for making J3 a bit more mariaDB aware.
Create an PR against the updater repo to ship the mariadb tag in the xmls
Based on: joomla/update.joomla.org#145 (comment) mariadb minimum is going to be 10,1 for now. Here is the update server PR to do the required change: joomla/update.joomla.org#146 cc @HLeithner @wilsonge
Update docs https://docs.joomla.org/Deploying_an_Update_Server
Added a note about the case implemented here.
@zero-24
Shall it define the supported versions, like the name of the item suggests, e.g. with a regex mariadb="10.[456]", or shall it be the minimum supported version for each DB? If the latter, then the name "supported_databases" might be a bit misleading.
P.S.: Is just a question for my understanding, not that I require any change. I can't test it anyway because I don't have MariaDB and for installing one it needs to kill my MySQL Db first, which I would like to avoid.