Please commit to 4.0-dev branch.

@coolcat-creations I have just moved the branch against 4.0-dev instead of staging so this can actually be merged ;)

@zero-24 thank you - but first the button-code needs to be fixed somehow...

would be better for you to create issues for the buttons that need fixing

Can you please elaborate what you mean with buttons being broken? Looking at the code, the buttons are pretty much identical, except that the dropdown buttons are wrapped in a div...

Can you please elaborate what you mean with buttons being broken? Looking at the code, the buttons are pretty much identical, except that the dropdown buttons are wrapped in a div...

Well I wrote it in the PR at the top... I added it also the the issue, hope that helps.
The Action Drop Down and the Module dropdown are different from save and close

vs

All these buttons have to have an icon?

All these buttons have to have an icon?

no they don't have to have an icon, but the install buttons on the control panel have so I suppose to be consistent in the types of buttons. If there is a save button with an icon, all save buttons should have this icon. If the install button has one, all install buttons should have the same. That UX...

If few buttons use btn-sm classes in the toolbar, the buttons in the toolbar should either use or not use this sizing class.

If there is a save button with an icon, all save buttons should have this icon. If the install button has one, all install buttons should have the same. That UX...

Of course that is good ux but we have to be able to support extensions that may not have defined an icon for everything. And in many places there is no need for an icon - example the Comment button here on github, the login button in the joomla admin, the documentation link in template styles.

I dont see any solid colour buttons in your first post. So there are no button styles that can be used. You have to have a button in white with a colour bar with an icon. This was not part of your design proposal

This is how regular bs buttons look like, they always look according to the style of the Joomla Buttons. Does not matter that they dont have icons. If they have Icons, the icons will appear in the squared colored area of the button. If there are no icons these squares a empty. this will unify the style of the template.

In the current 4.0dev the regular buttons look completely different from the ones used in Joomla, I think they should have the same appereance. Also if you add an icon to it they don't work. And don't work rtl with an icon inside. This PR here is fixing this. I think if I follow the suggestions from Charlie I can redo it in a better way but as said, the code has to be fixed still.

btw forget about my changes for the radio switch they need to be done different definetly :-)

It’s only unifying the button component use if every button has an icon though. Otherwise, to me all of those buttons look broken as if something is missing. If this is the design team coming down with a mandate that every button will have an icon, then so be it, just another decision people are going to either live with or hack around.

Consistency is good, but I feel like there needs to be two supported variations with this design; a button with an icon (which is what the current style is and fits the majority of use cases), and a “plain” style which is the “classic” full color buttons.

This is how regular bs buttons look like,

No they have no icons and coloured backgrounds not empty squares

This was not part of your design proposal

Ok, waiting then for the decision from the design team. I think it looks too colorful and chaotic when all those different button styles are used. Also the current ones (in the plain variation) don't work with icons inside.

Also the current ones (in the plain variation) don't work with icons inside.

Not true

No they have no icons and coloured backgrounds not empty squares

There is a misunderstanding. I meant how they look like with this PR. Without this PR they are solid colored and that does not fit to the template. But ok, who is in charge of design currently, maybe we can ask the design team?

Also the current ones (in the plain variation) don't work with icons inside.

Not true

See my screenshot, thats not how it looks nice... And if they have an icon they should look like the Joomla default ones...

Without this PR they are solid colored and that does not fit to the template.

What do you mean by does not fit the template - thats what they were in your design proposal

And if they have an icon

Without this PR they are solid colored and that does not fit to the template.

What do you mean by does not fit the template - thats what they were in your design proposal

Due to user feedback they were made less bold / screaming than in the design proposal from 2 years ago... so the style should be unified through the template. All the Joomla buttons have been redesigned and are changed. Why should the others be different than the regular Joomla Buttons. It makes the backend chaotic and less classy.

And where is this feedback. You keep mentioning it but I don't believe it has ever been made public.

Maybe I’m as blind as I’m considered a troll, but in all honesty the buttons in your screenshot look broken without icons to me. That button style comes across as needing an icon to make it look right, it all looks off to me with the empty squares.

Defaulting to the icon style is OK. Add a btn-noicon-* variant that takes buttons back to the default full color design (the same way Bootstrap ships the btn-outline-* variant) that way someone has to put in the extra effort to use that style but it’s still supported. I do think the icon style is going to be the primarily used style but I don’t think the icon style needs to be hardcoded and unavoidable. That’s my only concern with this, not that the design is bad but that it’s forcing specific design elements to always be used when they aren’t needed.

One thing that also caught my eye was that the:

1. Warning / Danger button colours look similar
2. Primary / Secondary colours look very similar

With that in mind, you may as well remove them from the colour array map. Or make them more distinguishable.

@C-Lodder I'd wait for a suggestion from the design team @brianteeman mentioned. IMHO all the Buttons in backend should follow an equal styling. Not some solid, some white with square color field at the front and others again different. Closing this PR for now until we have a design decision. The issue connected to this should stay open because it's about different markups and this should definetly be fixed.

Pretty sure I never said anything about a design team as I have no knowledge of one

Sorry, was a mistake, @mbabker mentioned a design team.