? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
29 Aug 2019

Pull Request for Issue # .

Summary of Changes

Adds prepared statements and cleans up queries in some form fields.

Testing Instructions

Install testing sample data. Go to backend.

  1. Go to Tags list. Inspect Select Tag Type field.
  2. Go to articles list. Inspect Select Author field.
  3. Edit a module. Inspect Module Style field.
  4. Go to Articles configuration. Inspect Choose a Layout field.
  5. Go to User manager, click on Permissions icon. Inspect Select Component field.
  6. Create Tagged Items menu item. In the form inspect Select Content Type field.
  7. Go to Template Manager. Edit a template file. Check that CodeMirror editor appears.

Expected result

Works like before.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 29 Aug 2019
avatar SharkyKZ SharkyKZ - change - 29 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2019
Category Libraries
ee26193 29 Aug 2019 avatar SharkyKZ CS
avatar SharkyKZ SharkyKZ - change - 29 Aug 2019
Labels Added: ?
avatar Quy Quy - test_item - 26 Sep 2019 - Tested successfully
avatar Quy
Quy - comment - 26 Sep 2019

I have tested this item successfully on 02554be


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26063.

avatar tushar33 tushar33 - test_item - 19 Oct 2019 - Tested unsuccessfully
avatar tushar33
tushar33 - comment - 19 Oct 2019

I have tested this item 🔴 unsuccessfully on e5e5f8a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26063.

avatar SharkyKZ
SharkyKZ - comment - 19 Oct 2019

@tushar33 What issue are you getting?

avatar tushar33
tushar33 - comment - 19 Oct 2019

Didn't get tags in article


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26063.

avatar SharkyKZ
SharkyKZ - comment - 1 Nov 2019

@tushar33 that's expected as explained in your issue #26679.

avatar jwaisner jwaisner - test_item - 8 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 8 Jan 2020

I have tested this item successfully on f3f8574


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26063.

avatar jwaisner
jwaisner - comment - 8 Jan 2020

@Quy can you retest this PR?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26063.

avatar jwaisner jwaisner - test_item - 14 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 14 Jan 2020

I have tested this item successfully on 47bb0c5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26063.

avatar Quy Quy - change - 14 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 14 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26063.

avatar HLeithner HLeithner - change - 14 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-14 10:31:58
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 14 Jan 2020
avatar HLeithner HLeithner - merge - 14 Jan 2020
avatar HLeithner
HLeithner - comment - 14 Jan 2020

Thanks

avatar HLeithner
HLeithner - comment - 14 Jan 2020

Thanks

Add a Comment

Login with GitHub to post a comment