? Pending

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
28 Aug 2019

Pull Request for Issue:
The JArchive class has been marked deprecated for Joomla 4.0 but it's not listed in libraries/classmap.php

Summary of Changes

This PR adds JArchive to libraries/classmap.php

avatar pe7er pe7er - open - 28 Aug 2019
avatar pe7er pe7er - change - 28 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Aug 2019
Category Libraries
avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Aug 2019
Title
[3.9] Added deprecated JArchive class to classmap
Added deprecated JArchive class to classmap
avatar franz-wohlkoenig franz-wohlkoenig - edited - 28 Aug 2019
avatar mbabker
mbabker - comment - 28 Aug 2019

It's not in the class map because there is still an actual JArchive class. Maybe this can be considered for 4.0, but I'd be hesitant about that because there are some minor differences between the archive classes the CMS provided and the archive classes from the Framework package (i.e. the Framework code doesn't use static methods whereas the CMS code does) that makes mapping a less-than-optimal choice.

avatar pe7er
pe7er - comment - 29 Aug 2019

Ok, I'll close this PR...
Thanks @mbabker for your explanation!

avatar pe7er pe7er - close - 29 Aug 2019
avatar pe7er pe7er - change - 29 Aug 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-08-29 13:06:11
Closed_By pe7er
Labels Added: ?

Add a Comment

Login with GitHub to post a comment