? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Aug 2019

Removes the css that changed the colour of the search button in the toolbar - it is not consistent with the blue used elsewhere in the toolbar such as list and direction

avatar brianteeman brianteeman - open - 26 Aug 2019
avatar brianteeman brianteeman - change - 26 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2019
Category Administration Templates (admin)
avatar Quy Quy - test_item - 27 Aug 2019 - Tested successfully
avatar Quy
Quy - comment - 27 Aug 2019

I have tested this item successfully on e4ecd75


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26042.

avatar richard67
richard67 - comment - 27 Aug 2019

@brianteeman There are still buttons in the same darker color as the search button currently has, e.g. in the articles list the "Options" and "Help" buttons. Will you change them with another PR?

avatar richard67 richard67 - test_item - 27 Aug 2019 - Tested successfully
avatar richard67
richard67 - comment - 27 Aug 2019

I have tested this item successfully on e4ecd75

Search button has now same colour as other buttons next to it, e.g. filter options, rows per page or ordering.

But there are still other buttons in the darker blue, like e.g. "Options" and "Help" buttons in the articles list view.

I assume those other buttons either shall not be changed or they will be changed with another PR, so I give this one here a good test because it does what it sais.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26042.

avatar brianteeman
brianteeman - comment - 27 Aug 2019

Nothing to stop you submitting a pr. You will have noticed I believe in one or for one task. Back to the beach and my cocktail

avatar richard67
richard67 - comment - 27 Aug 2019

@brianteeman Sure, one for each. Just wanted to know if you plan to do that so we don't do duplicate work. Have a good beach time.

avatar franz-wohlkoenig franz-wohlkoenig - change - 27 Aug 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 Aug 2019

Status "Ready To Commit".

avatar HLeithner HLeithner - change - 27 Aug 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-08-27 18:17:01
Closed_By HLeithner
Labels Added: ? ?
avatar HLeithner HLeithner - close - 27 Aug 2019
avatar HLeithner HLeithner - merge - 27 Aug 2019
avatar HLeithner
HLeithner - comment - 27 Aug 2019

thanks

avatar brianteeman
brianteeman - comment - 27 Aug 2019

Thanks

Add a Comment

Login with GitHub to post a comment