? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Aug 2019

This pr makes the date filter field the same width as the other filters. you can test this with the Banners->tracks filters

avatar brianteeman brianteeman - open - 26 Aug 2019
avatar brianteeman brianteeman - change - 26 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2019
Category Administration Templates (admin)
avatar Quy
Quy - comment - 27 Aug 2019

Could it be that the value 2019-08-26 is only 10 characters so don't need to be wider?

avatar brianteeman
brianteeman - comment - 27 Aug 2019
  1. consistency
  2. the hint text is truncated

image

avatar infograf768
infograf768 - comment - 27 Aug 2019

One of this template limitations.
In 3.x, we display the full format of the date to be entered for any language.

Screen Shot 2019-08-27 at 07 14 40

If the placeholder is truncated, which is the case before or after this PR, it is just useless.

Screen Shot 2019-08-27 at 07 23 22

Modifying globally the font-size and padding to something like
padding: 0.2rem 0.2rem;
font-size: 0.9rem;

would solve the issue, and this should be done imho in general in this template to get a better UI
Screen Shot 2019-08-27 at 07 52 25

avatar joomlaproffs
joomlaproffs - comment - 27 Aug 2019

I agree that the font size and paddings are a little bit to large in the new template "here and there". Just a little bit more consistency would be great.

avatar C-Lodder
C-Lodder - comment - 27 Aug 2019

Aren't the standard inputs set to 100% width so that the parent will dictate the width?

avatar brianteeman
brianteeman - comment - 27 Aug 2019

@C-Lodder you would be correct in thinking so but there is also a min-width set on the input of these filters AND for the calendar field it is an input with an additional button appended.

Don't care how its fixed but it should be fixed and instead of sitting there and moaning I tried to fix it

avatar C-Lodder
C-Lodder - comment - 27 Aug 2019

@brianteeman That's fine. Was just asking as this looks like a very dirty fix.

avatar brianteeman
brianteeman - comment - 27 Aug 2019

yes it is a dirty fix - all my css is like that. :(

avatar opn365 opn365 - test_item - 19 Oct 2019 - Tested unsuccessfully
avatar opn365
opn365 - comment - 19 Oct 2019

I have tested this item ? unsuccessfully on cb3378b

Did not change the width of the filter box


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26040.

avatar brianteeman
brianteeman - comment - 19 Oct 2019

@opn365 did you run npm i

avatar opn365
opn365 - comment - 19 Oct 2019

@brianteeman

@opn365 did you run npm i

did not for initial test but then ran npm and seemed to get the same result. (i was testing using pbf preloaded instance)

avatar LukasHH
LukasHH - comment - 19 Oct 2019

i would like add a css in the template.css with min-with, not font-size. eg:
.field-calendar > .input-group .form-control{ min-width: 15rem; }

avatar nadjak77
nadjak77 - comment - 19 Oct 2019

applied patch, run pm i, patch works but I think the input is still too small
image

avatar nadjak77 nadjak77 - test_item - 19 Oct 2019 - Tested successfully
avatar nadjak77
nadjak77 - comment - 19 Oct 2019

I have tested this item successfully on cb3378b

apply patch
run npm i
patch work
but I think the input is still too small


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26040.
avatar jaydevingawale jaydevingawale - test_item - 2 Nov 2019 - Tested successfully
avatar jaydevingawale
jaydevingawale - comment - 2 Nov 2019

I have tested this item successfully on cb3378b

I have tested this and its working correctly


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26040.

avatar brianteeman brianteeman - change - 30 Nov 2019
Labels Added: ?
avatar Quy
Quy - comment - 30 Nov 2019

While it looks good in English, it doesn't align in French (and possibility other languages) since the dropdown's width depends on the label's length and not a fixed width. Accessibility-wise, I assume it would be better to read the placeholder.

26040-french

avatar brianteeman brianteeman - change - 1 Dec 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-12-01 00:00:03
Closed_By brianteeman

Add a Comment

Login with GitHub to post a comment