[#26033] - [4.0] ContentHistoryHelper prepared statements
- Fixed in Code Base
- 30 Sep 2019
- Medium
- Build: 4.0-dev
- # 26033
- Diff
- SharkyKZ:j4/prepared/ContentHistoryHelper
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Adds prepared statements to Joomla\CMS\Helper\ContentHistoryHelper.
Testing Instructions
Simple queries, code review is fine.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26033.
i know that this is out of scope from this pr, but just saw this
and for "curly braces for PHP 7.4 compatibility" something like your #25782 ....
p.s.
dont' hate me
That's not wrong thats the correct syntax to access an variable object variable. PHP 7.4 deprecated accessing string indexes with this synatx $string{0} is not allowed anymore it have to be $string[0].
oops
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26033.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26033.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26033.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-09-30 12:50:58 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item✅ successfully on fb74f6a
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26033.