[#26012] - [4.0] Component and Plugin libraries prepared statements
- Fixed in Code Base
- 26 Aug 2019
- Medium
- Build: 4.0-dev
- # 26012
- Diff
- SharkyKZ:j4/prepared/Component_Plugin
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Adds prepared statements (whereIn) and cleans up queries in Joomla\CMS\Component and Joomla\CMS\Plugin namespaces.
Testing Instructions
Test that plugins and component still work, e.g. you can still login and can still access components.
Expected result
Works like before.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
Code review shows me it is correct and aligns queries to new J4 style but I do not see anything with prepared statements, so either I am blind or the title of this PR is a bit misleading.
stricly speaking you are right, it's more like a cleanup
Code review looks good, will check soon if it breaks something (what I don't expect).
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26012.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26012.
https://github.com/joomla/joomla-cms/pull/26012/files#diff-4a21854947e3cf421d4bb5d0a805271fR291
can be considered as prepared statement, but who cares , better if this will be merged asasp
| Title |
|
||||||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-26 09:54:38 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
thanks for the patch.
I have tested this item✅ successfully on 81d5701
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26012.