? ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
24 Aug 2019

Pull Request for Issue #25971

Summary of Changes

Display the Clear Expired Cache toolbar in the Clean Cache Manager (apparently wrong code in #24077 )
Also display info.
Taking off the presets menu items (Modern and System) still containing the wrong Menu item to the Purge view.
Deleting unused lang string as no more specific manager for Clear Expired Cache

Testing Instructions

Display the Maintenance: Clean cache

  1. Through System Dasboard
  2. When using the Modern Preset through the specific menu item

After patch

Screen Shot 2019-08-24 at 09 52 35

Modern preset
Screen Shot 2019-08-24 at 10 04 29

System Dashboard

Screen Shot 2019-08-24 at 10 05 18

avatar infograf768 infograf768 - open - 24 Aug 2019
avatar infograf768 infograf768 - change - 24 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2019
Category Administration com_cache com_menus Language & Strings
avatar richard67 richard67 - test_item - 24 Aug 2019 - Tested successfully
avatar richard67
richard67 - comment - 24 Aug 2019

I have tested this item successfully on 8652c05


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26003.

avatar brianteeman
brianteeman - comment - 24 Aug 2019

This PR is correct but
I still say that the whole concept of removing the purge view and merging it with the general cache view is completely wrong and provides a bad and confusing user experience.

There is no indicator anywhere on that page that expired cache items exist etc and clicking on the button doesn't change anything visible on the page - therefore the user thinks that nothing has happened and the button is broken

image

avatar infograf768
infograf768 - comment - 24 Aug 2019

I honestly don't care for one or the other.
The fact is that #24077 was merged and that the feature was broken which is now solved by this PR.
Therefore I don't mind if #24077 is reverted and this PR closed.
It is the responsibility of @wilsonge and Co to take this decision.

avatar infograf768 infograf768 - change - 25 Aug 2019
Labels Added: ? ?
avatar HLeithner
HLeithner - comment - 26 Aug 2019

I still say that the whole concept of removing the purge view and merging it with the general cache view is completely wrong and provides a bad and confusing user experience.

There is no indicator anywhere on that page that expired cache items exist etc and clicking on the button doesn't change anything visible on the page - therefore the user thinks that nothing has happened and the button is broken

Our expired cache purge only works on filesystem caching every other storage engine does nothing or try to fetch the item. So hey seams to clean it up automatically.

In my opinion the expired purge button doesn't seams important enough to have an own top level button.

avatar brianteeman
brianteeman - comment - 26 Aug 2019

Our expired cache purge only works on filesystem caching every other storage engine does nothing or try to fetch the item. So hey seams to clean it up automatically.

If true (i have no reason to doubt you I just havent checked) then the button should no even be displayed to those users who are not using filesystem caching.

In my opinion the expired purge button doesn't seams important enough to have an own top level button.

It is not about importance. Its about the user experience of clicking on the button and not seeing any changes

avatar HLeithner
HLeithner - comment - 26 Aug 2019

If true (i have no reason to doubt you I just havent checked) then the button should no even be displayed to those users who are not using filesystem caching.

I thought the same. For this caching API have to expose this information.

It is not about importance. Its about the user experience of clicking on the button and not seeing any changes

The message should be more informative.

avatar richard67 richard67 - test_item - 26 Aug 2019 - Tested successfully
avatar richard67
richard67 - comment - 26 Aug 2019

I have tested this item successfully on b120620


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26003.

avatar roland-d
roland-d - comment - 10 Sep 2019

The Clear Expired Cache in J3 doesn't show any changes either but it does show a message once clicked that the expired cache has been cleared. The same message pops up now if you click the button if I am not mistaken. Also now you get a confirmation that the operation succeeded/finished.

I cannot test at the moment @infograf768 due to the conflict.

avatar infograf768
infograf768 - comment - 10 Sep 2019

@roland-d
will try to solve the conflict tomorrow

avatar infograf768
infograf768 - comment - 11 Sep 2019

@roland-d @richard67
Please test now. the preset modern.xml was replaced by alternate.xml which explained the conflict.
Should be OK.

avatar roland-d roland-d - test_item - 11 Sep 2019 - Tested successfully
avatar roland-d
roland-d - comment - 11 Sep 2019

I have tested this item successfully on b3dbe0c

After applying the patch the purge expired cache link on the system page is moved to the Clear Cache page. A message is shown about the button. Users are informed this may be a resource intensive process when clicking the button.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26003.

avatar Schmidie64 Schmidie64 - test_item - 11 Sep 2019 - Tested successfully
avatar Schmidie64
Schmidie64 - comment - 11 Sep 2019

I have tested this item successfully on b3dbe0c

After applying the patch the purge expired cache link on the system page is moved to the Clear Cache page. I think it's a good idea to inform the user that this process may be a resource intensive.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26003.
avatar infograf768 infograf768 - change - 11 Sep 2019
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 11 Sep 2019

RTC thanks for testing.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26003.

avatar Quy Quy - change - 12 Sep 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 12 Sep 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-09-12 22:14:59
Closed_By wilsonge
avatar wilsonge wilsonge - close - 12 Sep 2019
avatar wilsonge wilsonge - merge - 12 Sep 2019
avatar wilsonge
wilsonge - comment - 12 Sep 2019

Thanks!

Add a Comment

Login with GitHub to post a comment