[#25981] - [4.0] Use setLimit() to set query limit
- Fixed in Code Base
- 26 Aug 2019
- Medium
- Build: 4.0-dev
- # 25981
- Diff
- SharkyKZ:j4/setLimit
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Limit and offset arguments of Joomla\Database\DatabaseInterface::setQuery() are deprecated. Use Joomla\Database\Query\LimitableInterface::setLimit() instead.
Testing Instructions
Code review?
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder com_languages com_postinstall Front End com_contact Libraries Modules |
| Labels |
Added:
?
|
||
Thanks. Added that too.
I have tested this item
1. Code review
Checked that every change made by this PR is correct.
Checked that this PR covers all calls to Joomla\Database\DatabaseInterface::setQuery() with deprecated arguments limit or offset or both in soures which belong to the CMS, i.e. not to external libraries.
- Functional test
Applied the PR and navigated a bit in backend and used a few functions, e.g. indexed com finder, and verified that nothing broken and nothing logged to PHP error log.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25981.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25981.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25981.
| Labels |
Added:
?
|
||
Conflicts fixed.
Thanks for setting the limit.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-26 13:11:32 |
| Closed_By | ⇒ | HLeithner |
@SharkyKZ Code review looks good regarding your changes, i.e. I've checked every single change is correct. But it seems you've missed one:
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_finder/Indexer/Adapter.php#L584
Or am I wrong?