? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
22 Aug 2019

Pull Request for Issue #25972.

Summary of Changes

Add handling for fonts with selected weight and styles.

Testing Instructions

Edit Protostar template style
Enable Google Font for Headings option.
In Google Font Name field enter a font with specific weights/styles, e.g. Open+Sans:400.
Inspect heading fonts in frontend.

Expected result

Headings use selected web font.

Actual result

Headings use standard font.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 22 Aug 2019
avatar SharkyKZ SharkyKZ - change - 22 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Aug 2019
Category Front End Templates (site)
avatar Quy Quy - test_item - 23 Aug 2019 - Tested successfully
avatar Quy
Quy - comment - 23 Aug 2019

I have tested this item successfully on 06efd35


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25976.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Aug 2019

@dioubernard please test (how to: https://docs.joomla.org/Testing_Joomla!_patches)

avatar richard67 richard67 - test_item - 24 Aug 2019 - Tested successfully
avatar richard67
richard67 - comment - 24 Aug 2019

I have tested this item successfully on 06efd35


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25976.

avatar franz-wohlkoenig franz-wohlkoenig - change - 24 Aug 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig franz-wohlkoenig - edited - 24 Aug 2019
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Aug 2019

Status "Ready To Commit".

avatar HLeithner HLeithner - close - 24 Aug 2019
avatar HLeithner HLeithner - merge - 24 Aug 2019
avatar HLeithner HLeithner - change - 24 Aug 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-08-24 16:41:18
Closed_By HLeithner
Labels Added: ? ?
avatar HLeithner
HLeithner - comment - 24 Aug 2019

Thanks for creating a better google font integration.

Add a Comment

Login with GitHub to post a comment