? ? Pending

User tests: Successful: Unsuccessful:

avatar ReLater
ReLater
21 Aug 2019

Pull Request for Issue #25958

Summary of Changes

  • Remove unnecessary condition for article title.

Testing Instructions

Code review.

avatar ReLater ReLater - open - 21 Aug 2019
avatar ReLater ReLater - change - 21 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2019
Category Front End com_content
avatar ReLater ReLater - change - 21 Aug 2019
The description was changed
avatar ReLater ReLater - edited - 21 Aug 2019
avatar SharkyKZ
SharkyKZ - comment - 21 Aug 2019

Could you also remove duplicate if ($params->get('show_title')) check 2 lines below?

avatar ReLater ReLater - change - 21 Aug 2019
Labels Added: ?
avatar SharkyKZ SharkyKZ - test_item - 21 Aug 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 21 Aug 2019

I have tested this item successfully on 4b5fd6d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25964.

avatar SharkyKZ
SharkyKZ - comment - 21 Aug 2019

I have tested this item successfully on 4b5fd6d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25964.

avatar Quy Quy - test_item - 21 Aug 2019 - Tested successfully
avatar Quy
Quy - comment - 21 Aug 2019

I have tested this item successfully on 4b5fd6d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25964.

avatar Quy Quy - change - 21 Aug 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 21 Aug 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25964.

avatar HLeithner
HLeithner - comment - 22 Aug 2019

Thank you for cleaning up the templates.

avatar HLeithner HLeithner - change - 22 Aug 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-08-22 17:06:29
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 22 Aug 2019
avatar HLeithner HLeithner - merge - 22 Aug 2019

Add a Comment

Login with GitHub to post a comment