[#25962] - [4.0] Fix missing method getDocument()
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
When i updating the methods, im getting a notice that the new methode is missing.
Factory::getApplication()->getDocument();
Testing Instructions
Update Factory::getDocument();
to Factory::getApplication()->getDocument();
Expected result
no deprecated message
Actual result
method 'getDocument' not found in Joomla\CMS\Application\CMSApplicationInterface
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
franz-wohlkoenig
- | Title |
|
||||||
The document doesn’t belong on this interface. CLI code doesn’t use it.
On Thu, Aug 22, 2019 at 12:40 AM SharkyKZ notifications@github.com wrote:
Either that or follow @mbabker https://github.com/mbabker's first
suggestion:changing doc blocks to accurate return types (i.e. classes instead of
interfaces)—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/joomla/joomla-cms/pull/25962?email_source=notifications&email_token=AACZ7IM2FOE2DBZ75YAM2W3QFYRETA5CNFSM4IOHNVHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD436HOY#issuecomment-523756475,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACZ7IJKSGPYUUBWJ3TH7MTQFYRETANCNFSM4IOHNVHA
.
--
- Michael Please pardon any errors, this message was sent from my iPhone.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25962.
Quy
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-01 16:52:44 |
| Closed_By | ⇒ | Quy |
This needs to be added to all classes extending
CMSApplicationInterface. Related issue #24587.