Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#25958] - Any plausible reason for show_author condition in article default.php

J3 Issue ?
avatar ReLater
ReLater
21 Aug 2019

Current Joomla 3.

Is there any plausible reason why there is an if condition for show_author around this code block that outputs the h2 headline?

https://github.com/joomla/joomla-cms/blob/3.9.11/components/com_content/views/article/tmpl/default.php#L50-L67

avatar ReLater ReLater - open - 21 Aug 2019
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Aug 2019
avatar ReLater ReLater - change - 21 Aug 2019
The description was changed
avatar ReLater ReLater - edited - 21 Aug 2019
avatar SharkyKZ
SharkyKZ - comment - 21 Aug 2019

No, it's a leftover from c36efc6#diff-7e2e52f4d2bbd0ec2a484d89a9e79817. Can be removed.

avatar ReLater
ReLater - comment - 21 Aug 2019

Thanks

In Joomla 3 and Joomla 4?

@HLeithner : Something critical concerning B\C

avatar HLeithner
HLeithner - comment - 21 Aug 2019

no concerns please write a pr if you have time for it.

avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Aug 2019
Labels Added: J3 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 21 Aug 2019
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Aug 2019

Closed as having Pull Request #25964

avatar franz-wohlkoenig franz-wohlkoenig - close - 21 Aug 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Aug 2019
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-08-21 16:34:19
Closed_By ⇒ franz-wohlkoenig

Add a Comment

Login with GitHub to post a comment