[#25954] - Missing Strings
- Fixed in Code Base
- 21 Aug 2019
- Medium
- Build: staging
- # 25954
- Diff
- brianteeman:strings
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
The following keys had no translation
JLIB_LOGIN_AUTHORISATION="Your access has been authorised."
JLIB_LOGIN_DENIED="Your access has been denied."
JLIB_LOGIN_EXPIRED="Your authentication has expired."
From the relevant section in the codebase it is not very clear exactly what they should be
// Validate that the user should be able to login (different to being authenticated). // This permits authentication plugins blocking the user
So these are fairly generic and the plugin creator can override them if they want. Nothing in core will trigger them to be displayed so I wouldn't waste much time on them.
Pull Request for Issue #25930 .
Testing Instructions
Code review only
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25954.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25954.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-21 10:48:36 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
tks
wow less than 1 hour
Thanks
@infograf768 can you correct the Milestone please
done
I have tested this item✅ successfully on 1fa6d10
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25954.