No Code Attached Yet ? bug
avatar micker
micker
21 Aug 2019

Steps to reproduce the issue

as i can test changing bootstrap grid for dashboard module doesn't works :
1 edit quickicon module
2 set bootstrap size to 12

Expected result

module need to display in full width

Actual result

=> no change module is display in 1/2

avatar micker micker - open - 21 Aug 2019
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Aug 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Aug 2019
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 21 Aug 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Aug 2019
Status New Discussion
avatar ghost
ghost - comment - 23 Aug 2019

Issue confirmed.

avatar micker
micker - comment - 23 Aug 2019

thanks

avatar micker
micker - comment - 27 Apr 2020

for me its important to correct this because it will break all admin module ! impossible to create a full width dashboard (virtuemart hikashop, custom dashboard)

avatar coolcat-creations
coolcat-creations - comment - 27 Apr 2020

Also it needs 4 BS classes for the different breakpoints and not only one, or not?

avatar micker
micker - comment - 3 May 2020

i realy think we need to add possibility to have width module for dashboard .. maybe need to add grid class ?

avatar coolcat-creations
coolcat-creations - comment - 4 May 2020

Agree, the module class suffix can't be used for the grid. Just tested it...

avatar micker
micker - comment - 4 May 2020

sorry i don't understand i need to test someting ?

avatar coolcat-creations
coolcat-creations - comment - 4 May 2020

@micker - you can set up a module class suffix but I just tested, it does not solve the issue you have to the fullest...

avatar coolcat-creations
coolcat-creations - comment - 10 May 2020

@C-Lodder and @ciar4n - can you help on this issue? What needs to be changed exactly? We have grid-template-columns: 1fr 1fr; for the card-columns, does that have to be changed to a more generic columns like 12 x 1fr or so? Do we need breakpoint parameters in the modules? I can create a PR but I don't know what has to be done to solve it.

avatar micker
micker - comment - 9 Sep 2020

i test with suffix, bs class nothing works
@C-Lodder @ciar4n we realy need some imporvement here because all dashboard function can be display in 2 columns !

avatar micker
micker - comment - 17 Sep 2020

in j4
2020-09-17_17h07_51
in j3
2020-09-17_17h09_19
all admin module are impacts !!!

avatar micker
micker - comment - 30 Sep 2020

@coolcat-creations @ciar4n @C-Lodder @angieradtke
for me 2 solutions

  • adding column class for module (mb3, mb2, mb12 ..)
  • using postion, for now icon, cpanel => display same ... maybe we can add a full width position ?
avatar micker
micker - comment - 2 Oct 2020

Sorry i will try to bump more person @brianteeman ?

avatar micker
micker - comment - 2 Oct 2020

Lol @brianteeman i try to motived lead contributor... I know you cant solve all thing with your little hand ?

avatar angieradtke
angieradtke - comment - 2 Oct 2020

Hi
maybe this could help, just an idea

.card-columns {
grid-template-columns: repeat(auto-fit,minmax(max(calc(50% - 30px),250px),1fr));
}

All the best, stay healthy .-)
Angie

avatar micker
micker - comment - 2 Oct 2020

Cool angie ...I dont understand why bs class in module backend doesnt works ...

avatar angieradtke
angieradtke - comment - 3 Oct 2020

I think, here we are dealing width css-grid and bootstraps flexbox-grid. 2 techniques are mixed.

avatar micker
micker - comment - 3 Oct 2020

@georgewilson maybe ? ?

avatar micker
micker - comment - 7 Oct 2020

@angieradtke your code works but strange to need to override an existing function ??
@wilsonge any idea why the backend template can't use bs according module option ?

avatar micker
micker - comment - 11 Mar 2021

hello i test last version with BS5 no evolution please don't ignore it !

avatar brianteeman
brianteeman - comment - 6 Apr 2021

Please test #33045

avatar Quy Quy - change - 6 Apr 2021
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2021-04-06 21:43:13
Closed_By Quy
avatar Quy Quy - close - 6 Apr 2021
avatar infograf768
infograf768 - comment - 7 Apr 2021

afaik #33045 will not let full width display as we have a grid separating the modules in 2 columns with
grid-template-columns: 1fr 1fr; and therefore full width concerns only one column.

avatar micker
micker - comment - 7 Apr 2021

thanks @infograf768 @Quy can you reopen this issue ?

avatar infograf768 infograf768 - change - 7 Apr 2021
Status Closed New
Closed_Date 2021-04-06 21:43:13
Closed_By Quy
avatar infograf768 infograf768 - reopen - 7 Apr 2021
avatar infograf768
infograf768 - comment - 7 Apr 2021

I guess this can be overriden for a specific component dashboard though.
Example: class="cpanel-modules cpanel-mycomponent"

.cpanel-mycomponent {
  .card-columns {
      grid-template-columns: 1fr;
  }
}
avatar brianteeman
brianteeman - comment - 7 Apr 2021

That is the only way other than creating your own admin template

avatar micker
micker - comment - 7 Apr 2021

yes we can do this, but that realy dommage to kill an old beahvior (j3 heritage with cpanel in full width) to limit it in 2 columns only
team do an important work to add bs5 in admin but we can use it ...
@ciar4n @dgrammatiko no way to keep this ?

avatar dgrammatiko
dgrammatiko - comment - 7 Apr 2021

Someone could implement a design mode, similar to https://perfectgrid.io/demo and thus allow the modification of both the width and height. That said I must also note that the way things are handled in the com_cpanel (the API for the modules, etc) is at least naive and very unfriendly to devs, so, imho the com_cpanel needs way more refactoring than adding some widget for height and width for individual modules...

avatar micker
micker - comment - 7 Apr 2021

@dgrammatiko it can be powerfull but maybe to many works for a 4.0, if only allow to use width option according module option value we can easly create 1-2-3-4 columns

avatar ciar4n
ciar4n - comment - 7 Apr 2021

It's not that simple as the current dashboard is a masonry layout. The current js for that layout will not handle varied widths. As I see it there are 3 options...

  1. Use a more advanced masonry js (eg. https://masonry.desandro.com/)
  2. Implement a layout builder as suggested by @dgrammatiko
  3. Create a new module position above the current 2 column masonry layout which will work with your bootstrap classes. This is probably the only viable option.
avatar micker
micker - comment - 7 Apr 2021

Yes the layout builder Can be cool but maybe too powerfull... A fullwidth position on top (before 2 columns) Can be simplier
@ciar4n i am agree

avatar Hackwar Hackwar - change - 19 Feb 2023
Labels Added: No Code Attached Yet bug
Removed: ?
avatar Hackwar Hackwar - labeled - 19 Feb 2023

Add a Comment

Login with GitHub to post a comment