? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
21 Aug 2019

Pull Request for Issue # .

Summary of Changes

use the ?? (Null Coalescing Operator) to get 0 instead of ""

Testing Instructions

create an admin using Import a preset

Expected result

able to create admin menu

Actual result

SQL ERROR: invalid input syntax for integer: ""

avatar alikon alikon - open - 21 Aug 2019
avatar alikon alikon - change - 21 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2019
Category Administration com_menus
avatar richard67 richard67 - test_item - 25 Aug 2019 - Tested successfully
avatar richard67
richard67 - comment - 25 Aug 2019

I have tested this item successfully on bbeb9fd

Fixes the mentioned SQL error.

Other oddities with custom admin menus and presets on PostgreSQL or other PostgreSQL issues are not subject of this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25949.

avatar Quy
Quy - comment - 19 Oct 2019

Please confirm that this will fix #26713.

avatar waader
waader - comment - 19 Oct 2019

@Quy: the error has gone, but also all menu items.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25949.

avatar alikon
alikon - comment - 23 Oct 2019

i can confirm @waader findings
....2 months after ..... this PR is ....
closing

avatar alikon alikon - close - 23 Oct 2019
avatar alikon alikon - change - 23 Oct 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-10-23 17:13:28
Closed_By alikon
Labels Added: ?
avatar richard67
richard67 - comment - 24 Oct 2019

@alikon Maybe you should just have used 1 instead of 0 as default? The menu item with id 1 is the root, and this is also the default value for the parent_id column in the menu table in database. Do you want to make a new PR for it?

avatar alikon
alikon - comment - 24 Oct 2019

Add a Comment

Login with GitHub to post a comment