[#25932] - Function Redis::delete() is deprecated
- Fixed in Code Base
- 19 Aug 2019
- Medium
- Build: staging
- # 25932
- Diff
- acs-ferreira:patch-4
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Function Redis::delete() is deprecated in phpredis 5
Testing Instructions
Install phpredis 5, it trows a deprecated warning. As delete is an alias for del, this is backards compatible.
See the note at https://github.com/phpredis/phpredis#del-delete-unlink
Expected result
No PHP warnings.
Actual result
PHP deprecated warning.
Deprecated: Function Redis::delete() is deprecated in /libraries/src/Cache/Storage/RedisStorage.php on line 341
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
PECL says 2.2.3 was the first public release, I don't get why breaking support for anything older than that is a problem because by the author's own statement anything older can basically be considered a beta or release candidate.
I checked the releases on github there is even a 1.2 release but if you think pecl is the only relevant source we can merge this.
As it relates to PHP extensions, I would consider PECL the canonical source. And considering the release notes for 2.2.3 explicitly says "First public release" then I would take the author's word that anything older doesn't need to be considered. Is it important to keep supporting 0.x releases from someone after they've created a 1.0 release?
Same concept basically, just weird version numbering.
ok perfect thx for the guidance.
Many thanks to @acs-ferreira for your second successfully merged Joomla PR
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-19 14:37:39 |
| Closed_By | ⇒ | HLeithner |
The
delfunction is only supported since phpredis 2.1 since we still support PHP 5.3 it's possible to break installations with phpredis 2.0Any comment from @mbabker would be welcome.